From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by sourceware.org (Postfix) with ESMTPS id 599013858D35; Tue, 8 Mar 2022 19:21:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 599013858D35 From: Hans-Peter Nilsson To: , Subject: [PATCH] toplevel: Makefile.def: Make configure-sim depend on all-readline MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Message-ID: <20220308192128.A2D462041A@pchp3.se.axis.com> Date: Tue, 8 Mar 2022 20:21:28 +0100 X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2022 19:21:32 -0000 Calling on "global maintainers" as per toplevel/MAINTAINERS for "Makefile.*". Ok to commit? (If so, I'll also commit this change to the gcc repo, where this dependency is normally unused, i.e. when source trees are kept separate.) brgds, H-P ----- 8< ----- Without this, a "make all-sim" without the equivalent of libreadline-dev installed on the build system, won't properly pick up the in-tree readline build, and you'll see: mkdir -p -- ./sim Configuring in ./sim configure: creating cache ./config.cache checking build system type... x86_64-pc-linux-gnu checking host system type... x86_64-pc-linux-gnu checking target system type... cris-axis-elf checking for x86_64-pc-linux-gnu-gcc... gcc checking whether the C compiler works... yes ... checking for library containing tgetent... -ltermcap checking for readline in -lreadline... no configure: error: the required "readline" library is missing make[1]: *** [Makefile:11188: configure-sim] Error 1 make[1]: Leaving directory '/home/hp/sim/b' The sim dependency on readline is apparently (nominally) valid as there's a readline call in sim/erc32/sis.c. 2022-02-21 Hans-Peter Nilsson * Makefile.def (dependencies): Make configure-sim depend on all-readline. --- Makefile.def | 2 +- Makefile.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.def b/Makefile.def index a504192e6d72..8181a7aa97b5 100644 --- a/Makefile.def +++ b/Makefile.def @@ -570,7 +570,7 @@ dependencies = { module=all-sim; on=all-intl; }; dependencies = { module=all-sim; on=all-libiberty; }; dependencies = { module=all-sim; on=all-bfd; }; dependencies = { module=all-sim; on=all-opcodes; }; -dependencies = { module=all-sim; on=all-readline; }; +dependencies = { module=configure-sim; on=all-readline; }; // Other host modules. dependencies = { module=all-fastjar; on=all-zlib; }; diff --git a/Makefile.in b/Makefile.in index 2b77a4706947..843e150dac63 100644 --- a/Makefile.in +++ b/Makefile.in @@ -63072,7 +63072,7 @@ install-strip-sid: maybe-install-strip-tcl install-sid: maybe-install-tk install-strip-sid: maybe-install-strip-tk configure-sim: maybe-all-gnulib -all-sim: maybe-all-readline +configure-sim: maybe-all-readline all-fastjar: maybe-all-build-texinfo all-libctf: all-libiberty all-stage1-libctf: all-stage1-libiberty -- 2.30.2