From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by sourceware.org (Postfix) with ESMTPS id D0CA93858D3C for ; Fri, 11 Mar 2022 09:40:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D0CA93858D3C Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 22B6L56H032282; Fri, 11 Mar 2022 10:40:26 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3em034nyeu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Mar 2022 10:40:26 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 26EC110002A; Fri, 11 Mar 2022 10:40:25 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 062DA216EC5; Fri, 11 Mar 2022 10:40:25 +0100 (CET) Received: from gnbcxd0114.gnb.st.com (10.75.127.45) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.26; Fri, 11 Mar 2022 10:40:24 +0100 Date: Fri, 11 Mar 2022 10:40:23 +0100 From: Yvan Roux To: Christophe Lyon CC: Joel Brobecker , , "Maxim Kuvyrkov via Gdb-patches" Subject: Re: [PATCH v3 0/5] arm: Add support for multiple stacks on Cortex-M Message-ID: <20220311094023.GA22664@gnbcxd0114.gnb.st.com> References: <20220204084151.14480-1-christophe.lyon@gmail.com> <45235B67-731E-4EE7-81E1-62A720E963A4@linaro.org> <53361ca7-d2fe-79d7-7e34-cdf5e3656174@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <53361ca7-d2fe-79d7-7e34-cdf5e3656174@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-11_03,2022-03-11_01,2022-02-23_01 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 09:40:32 -0000 Hi, I'll let Christophe address the comments and update the patchset, but I was able to test it on an arm linux plateform I don't see any regression in the testsuite. Sorry I wasn't on the list when the patches were submitted, but I think there is a small issue this one: [PATCH v3 1/5] gdb/arm: Fix prologue analysis to support vpush + /* Calculate offsets of saved registers. */ + for (; number > 0; number--) + { + addr = pv_add_constant (addr, -8); + stack.store (addr, 8, pv_register (ARM_D0_REGNUM + number, 0)); + } Here the D registers to store are computed by adding number to D0 but the first register should be the one encoded by D:Vd value which are bits 6 of insn and 15..12 of inst2 Cheers, Yvan On Sun, Mar 06, 2022 at 10:19:52PM +0100, Christophe Lyon via Gdb-patches wrote: > > > On 3/6/22 11:48, Joel Brobecker wrote: > > > > > Will you be able to review this patch series from Christophe? > > > > I see that the v3 series was posted on Feb 4th, while on Feb 6th > > > > I reviewed v2 :-(. This is really unfortunate that we don't have > > > > a better system for tracking whether a version of a series is > > > > trully the latest version. > > > > > > No problem, there's not much difference between v2 and v3, > > > so your comments still apply. I should have answered earlier. > > > > > > > > > > > Can you take a look at the comments and question I asked in v2, > > > > and publish a v4 which takes those into account? Please Cc: me > > > > on the submission of the patches, this will help me remember > > > > to prioritize those patches. > > > > > > > > > Sure! > > > > > > Luis and I changed jobs at the same time, so there's a bit > > > of lag :-) > > > > No problem! > > > > Just for the avoidance of doubt and you don't end up waiting on me, > > my understanding is that the next step is for you to produce a v4 > > with some of my comments addressed, and to post answers/questions > > for my comments. Is that right? > > > > Yes, that's what I meant :-) > > Thanks, > > Christophe -- Y.