From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: [PUSHED] gdb/testsuite: remove duplicates from gdb.base/stap-probe.exp
Date: Fri, 11 Mar 2022 15:31:12 +0000 [thread overview]
Message-ID: <20220311153112.2559786-1-aburgess@redhat.com> (raw)
Remove the duplicate test names from gdb.base/stap-probe.exp, this is
done by actually passing a unique test name in a couple of
places (rather than using the command as the test name), and in
another couple of places, a test has a duplicate name due to a cut &
paste error, which I've fixed.
There's no change in what is actually being tested after this commit.
---
gdb/testsuite/gdb.base/stap-probe.exp | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/gdb/testsuite/gdb.base/stap-probe.exp b/gdb/testsuite/gdb.base/stap-probe.exp
index 6d521870c10..e86c7897b93 100644
--- a/gdb/testsuite/gdb.base/stap-probe.exp
+++ b/gdb/testsuite/gdb.base/stap-probe.exp
@@ -29,7 +29,9 @@ proc stap_test {exec_name {args ""}} {
set semaphore_addr_var ""
if {[string first "-DUSE_SEMAPHORES" $args] == -1} {
gdb_test_no_output "set breakpoint always-inserted on"
- set semaphore_addr_var [get_hexadecimal_valueof "&relocation_marker" "0"]
+ set semaphore_addr_var \
+ [get_hexadecimal_valueof "&relocation_marker" "0"\
+ "get original address of relocation_marker"]
}
if ![runto_main] {
@@ -54,8 +56,11 @@ proc stap_test {exec_name {args ""}} {
}
if {[string first "-DUSE_SEMAPHORES" $args] == -1} {
+ set updated_semaphore_addr_var \
+ [get_hexadecimal_valueof "&relocation_marker" \
+ "0" "get revised relocation_marker address"]
set relocation_base \
- [expr [get_hexadecimal_valueof "&relocation_marker" "0"] - $semaphore_addr_var]
+ [expr $updated_semaphore_addr_var - $semaphore_addr_var]
if {$relocation_base != 0} {
# Checks that GDB doesn't mistakenly relocate and write to null
# semaphore addresses. If it were to relocate a zero-valued
@@ -103,9 +108,9 @@ proc stap_test {exec_name {args ""}} {
# Reinit GDB, set a breakpoint on probe ps.
delete_breakpoints
if {[runto "-pstap test:ps"]} {
- pass "run to -pstap test:m4"
+ pass "run to -pstap test:ps"
} else {
- fail "run to -pstap test:m4"
+ fail "run to -pstap test:ps"
}
gdb_test "print \$_probe_argc" " = 3" \
@@ -169,9 +174,9 @@ proc stap_test_no_debuginfo {exec_name {args ""}} {
# Reinit GDB, set a breakpoint on probe ps.
delete_breakpoints
if {[runto "-pstap test:ps"]} {
- pass "run to -pstap test:m4"
+ pass "run to -pstap test:ps"
} else {
- fail "run to -pstap test:m4"
+ fail "run to -pstap test:ps"
}
gdb_test "print \$_probe_argc" " = 3" \
--
2.25.4
reply other threads:[~2022-03-11 15:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220311153112.2559786-1-aburgess@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).