From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.baldwin.cx (bigwig.baldwin.cx [66.216.25.90]) by sourceware.org (Postfix) with ESMTPS id 14135394BE34 for ; Wed, 16 Mar 2022 19:36:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14135394BE34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=FreeBSD.org Received: from ralph.com (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 139EC1A84C6B for ; Wed, 16 Mar 2022 15:36:48 -0400 (EDT) From: John Baldwin To: gdb-patches@sourceware.org Subject: [PATCH] Avoid harmful fall throughs in core_target::xfer_partial. Date: Wed, 16 Mar 2022 12:36:04 -0700 Message-Id: <20220316193604.89477-1-jhb@FreeBSD.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (mail.baldwin.cx [0.0.0.0]); Wed, 16 Mar 2022 15:36:49 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.103.1 at mail.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_STATUS, KHOP_HELO_FCRDNS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 19:36:51 -0000 The cases for TARGET_OBJECT_LIBRARIES and TARGET_OBJECT_LIBRARIES_AIX can try to fetch different data objects (such as TARGET_OBJECT_SIGNAL_INFO) if gdbarch methods for the requested data aren't present. Replace case fallthroughs with an explicit goto to the default case. --- gdb/corelow.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdb/corelow.c b/gdb/corelow.c index 1579e6bc2b8..f7f2bd3f318 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -943,7 +943,7 @@ core_target::xfer_partial (enum target_object object, const char *annex, return TARGET_XFER_OK; } } - /* FALL THROUGH */ + goto fallthrough; case TARGET_OBJECT_LIBRARIES_AIX: if (m_core_gdbarch != nullptr @@ -964,7 +964,7 @@ core_target::xfer_partial (enum target_object object, const char *annex, return TARGET_XFER_OK; } } - /* FALL THROUGH */ + goto fallthrough; case TARGET_OBJECT_SIGNAL_INFO: if (readbuf) @@ -988,6 +988,7 @@ core_target::xfer_partial (enum target_object object, const char *annex, return TARGET_XFER_E_IO; default: + fallthrough: return this->beneath ()->xfer_partial (object, annex, readbuf, writebuf, offset, len, xfered_len); -- 2.34.1