From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org
Cc: Willgerodt, Felix <felix.willgerodt@intel.com>
Subject: [RFC PATCH v2 0/5] Handle variable XSAVE layouts
Date: Thu, 17 Mar 2022 11:35:58 -0700 [thread overview]
Message-ID: <20220317183603.34789-1-jhb@FreeBSD.org> (raw)
Changes since V1:
- Renamed xsave_offsets to x86_xsave_layout and added a total size
member.
- Fetch the x86_xsave_layout in i386_gdbarch_init and save it in a new
member of i386_gdbarch_tdep.
- Patch 1 now only deals with defining the new structure and adding it
to the tdep.
- The i387_set_xsave_layout helper function is moved to patch 2 and
the description has been updated to be more explicit about it being
a fallback to be supplanted in the future by a new core dump note.
- The changes to i387-tdep.c to change the XSAVE parsing has now been
moved to the end in patch 5. It also now uses the new member from
tdep instead of reading from the target every time.
- Patch 3 (FreeBSD core dump support changes) uses the XSAVE size
saved in the tdep member as the register set size and no longer uses
REGSET_VARIABLE_SIZE. This should properly honor the native CPU's
layout when writing a core dump via gcore.
John Baldwin (5):
x86: Add an x86_xsave_layout structure to handle variable XSAVE
layouts.
core: Support fetching TARGET_OBJECT_X86_XSAVE_LAYOUT from
architectures.
Update x86 FreeBSD architectures to support XSAVE layouts.
Support XSAVE layouts for the current host in the FreeBSD/amd64
target.
x86: Use x86_xstate_layout to parse the XSAVE extended state area.
gdb/amd64-fbsd-nat.c | 90 ++++++-
gdb/amd64-fbsd-tdep.c | 8 +-
gdb/corelow.c | 22 ++
gdb/gdbarch-components.py | 13 +
gdb/gdbarch-gen.h | 10 +
gdb/gdbarch.c | 32 +++
gdb/i386-fbsd-tdep.c | 37 ++-
gdb/i386-fbsd-tdep.h | 6 +
gdb/i386-tdep.c | 36 ++-
gdb/i386-tdep.h | 30 +++
gdb/i387-tdep.c | 491 ++++++++++++++++++++++++--------------
gdb/i387-tdep.h | 8 +
gdb/target.h | 2 +
13 files changed, 594 insertions(+), 191 deletions(-)
--
2.34.1
next reply other threads:[~2022-03-17 18:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 18:35 John Baldwin [this message]
2022-03-17 18:35 ` [RFC PATCH v2 1/5] x86: Add an x86_xsave_layout structure to handle " John Baldwin
2022-03-17 18:36 ` [RFC PATCH v2 2/5] core: Support fetching TARGET_OBJECT_X86_XSAVE_LAYOUT from architectures John Baldwin
2022-03-28 11:28 ` George, Jini Susan
2022-03-17 18:36 ` [RFC PATCH v2 3/5] Update x86 FreeBSD architectures to support XSAVE layouts John Baldwin
2022-03-17 18:36 ` [RFC PATCH v2 4/5] Support XSAVE layouts for the current host in the FreeBSD/amd64 target John Baldwin
2022-03-17 18:36 ` [RFC PATCH v2 5/5] x86: Use x86_xstate_layout to parse the XSAVE extended state area John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220317183603.34789-1-jhb@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).