From: John Baldwin <jhb@FreeBSD.org>
To: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: [PATCH 01/12] Handle another edge case for TLS variable lookups.
Date: Wed, 23 Mar 2022 14:00:40 -0700 [thread overview]
Message-ID: <20220323210048.25525-2-jhb@FreeBSD.org> (raw)
In-Reply-To: <20220323210048.25525-1-jhb@FreeBSD.org>
This is similar to the change in
df22c1e5d53c38f38bce6072bb46de240f9e0e2b but applies to the main
object file. The original change I encountered when testing TLS on
RISC-V for which I was unable to test TLS variables in the main
executable due to issues with compiler-generated debug info, so I only
checked for a backlink before walking the list of shared library
object files.
However, I ran into this issue again (of a separate debug object file
being passed to svr4_fetch_objfile_link_map) when testing TLS
variables on 32-bit arm. To fix, move the check for a backlink
earlier before the check for the main object file.
---
gdb/solib-svr4.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
index 69f2991f5e6..aba476f6cf2 100644
--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -1449,15 +1449,15 @@ svr4_fetch_objfile_link_map (struct objfile *objfile)
if (info->main_lm_addr == 0)
solib_add (NULL, 0, auto_solib_add);
- /* svr4_current_sos() will set main_lm_addr for the main executable. */
- if (objfile == current_program_space->symfile_object_file)
- return info->main_lm_addr;
-
/* If OBJFILE is a separate debug object file, look for the
original object file. */
if (objfile->separate_debug_objfile_backlink != NULL)
objfile = objfile->separate_debug_objfile_backlink;
+ /* svr4_current_sos() will set main_lm_addr for the main executable. */
+ if (objfile == current_program_space->symfile_object_file)
+ return info->main_lm_addr;
+
/* The other link map addresses may be found by examining the list
of shared libraries. */
for (struct so_list *so : current_program_space->solibs ())
--
2.34.1
next prev parent reply other threads:[~2022-03-23 21:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 21:00 [PATCH 00/12] * Support for Thread Local Storage (TLS) variables on FreeBSD arm and aarch64 architectures John Baldwin
2022-03-23 21:00 ` John Baldwin [this message]
2022-03-23 23:55 ` [PATCH 01/12] Handle another edge case for TLS variable lookups John Baldwin
2022-03-24 0:26 ` John Baldwin
2022-03-23 21:00 ` [PATCH 02/12] fbsd-nat: Add helper routines for register sets using PT_[G]SETREGSET John Baldwin
2022-03-24 8:51 ` Luis Machado
2022-03-24 17:45 ` John Baldwin
2022-03-23 21:00 ` [PATCH 03/12] Create pseudo sections for NT_ARM_TLS notes on FreeBSD John Baldwin
2022-03-23 21:00 ` [PATCH 04/12] Add an arm-tls feature which includes the tpidruro register from CP15 John Baldwin
2022-04-04 8:01 ` Luis Machado
2022-04-12 23:36 ` John Baldwin
2022-04-14 10:23 ` Luis Machado
2022-04-19 16:18 ` John Baldwin
2022-04-20 6:59 ` Luis Machado
2022-03-23 21:00 ` [PATCH 05/12] Read the tpidruro register from NT_ARM_TLS core dump notes on FreeBSD/arm John Baldwin
2022-03-23 21:00 ` [PATCH 06/12] Support TLS variables " John Baldwin
2022-03-23 21:00 ` [PATCH 07/12] Fetch the NT_ARM_TLS register set for native FreeBSD/arm processes John Baldwin
2022-03-23 21:00 ` [PATCH 08/12] Add an aarch64-tls feature which includes the tpidr register John Baldwin
2022-03-28 10:16 ` Luis Machado
2022-04-01 23:30 ` John Baldwin
2022-04-04 8:06 ` Luis Machado
2022-04-04 12:18 ` Luis Machado
2022-05-03 21:14 ` Luis Machado
2022-05-03 21:30 ` John Baldwin
2022-05-03 21:34 ` Luis Machado
2022-03-23 21:00 ` [PATCH 09/12] Read the tpidr register from NT_ARM_TLS core dump notes on FreeBSD/Aarch64 John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220323210048.25525-2-jhb@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).