From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2607:f138:0:13::2]) by sourceware.org (Postfix) with ESMTPS id 9D2203858C54; Thu, 24 Mar 2022 20:56:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9D2203858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=FreeBSD.org Received: from ralph.com (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id E75D41A84C70; Thu, 24 Mar 2022 16:56:22 -0400 (EDT) From: John Baldwin To: binutils@sourceware.org, gdb-patches@sourceware.org Subject: [PATCH 1/5] elfcore_grok_freebsd_note: Remove checks of note->namesz. Date: Thu, 24 Mar 2022 13:56:12 -0700 Message-Id: <20220324205616.8517-2-jhb@FreeBSD.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220324205616.8517-1-jhb@FreeBSD.org> References: <20220324205616.8517-1-jhb@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (mail.baldwin.cx [0.0.0.0]); Thu, 24 Mar 2022 16:56:23 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.103.1 at mail.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_STATUS, KHOP_HELO_FCRDNS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2022 20:56:24 -0000 This function is only called if the note name is "FreeBSD", so checking the name size is unnecessary. bfd/ChangeLog: * elf.c (elfcore_grok_freebsd_note): Remove checks for namesz. --- bfd/ChangeLog | 4 ++++ bfd/elf.c | 10 ++-------- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 86d42b2d639..d1a31efe59c 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,7 @@ +2022-03-23 John Baldwin + + * elf.c (elfcore_grok_freebsd_note): Remove checks for namesz. + 2022-03-22 Steiner H Gunderson * dwarf2.c (_bfd_dwarf2_find_nearest_line): if a function name is diff --git a/bfd/elf.c b/bfd/elf.c index 82b53be99f9..a99149e50b3 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -11010,10 +11010,7 @@ elfcore_grok_freebsd_note (bfd *abfd, Elf_Internal_Note *note) return elfcore_grok_freebsd_psinfo (abfd, note); case NT_FREEBSD_THRMISC: - if (note->namesz == 8) - return elfcore_make_note_pseudosection (abfd, ".thrmisc", note); - else - return true; + return elfcore_make_note_pseudosection (abfd, ".thrmisc", note); case NT_FREEBSD_PROCSTAT_PROC: return elfcore_make_note_pseudosection (abfd, ".note.freebsdcore.proc", @@ -11031,10 +11028,7 @@ elfcore_grok_freebsd_note (bfd *abfd, Elf_Internal_Note *note) return elfcore_make_auxv_note_section (abfd, note, 4); case NT_X86_XSTATE: - if (note->namesz == 8) - return elfcore_grok_xstatereg (abfd, note); - else - return true; + return elfcore_grok_xstatereg (abfd, note); case NT_FREEBSD_PTLWPINFO: return elfcore_make_note_pseudosection (abfd, ".note.freebsdcore.lwpinfo", -- 2.34.1