From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0DC29385DC2D for ; Fri, 25 Mar 2022 03:44:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0DC29385DC2D Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-670-OqF2gKG3O5GPlsa5Q5_Qdg-1; Thu, 24 Mar 2022 23:44:26 -0400 X-MC-Unique: OqF2gKG3O5GPlsa5Q5_Qdg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 18FAB100E659; Fri, 25 Mar 2022 03:44:26 +0000 (UTC) Received: from f35-1.lan (unknown [10.2.16.88]) by smtp.corp.redhat.com (Postfix) with ESMTP id A0CD342B937; Fri, 25 Mar 2022 03:44:25 +0000 (UTC) From: Kevin Buettner To: gdb-patches@sourceware.org Subject: [PATCH v2 2/2] [symtab/27831] New test case: gdb.base/add-symbol-file-attach.exp Date: Thu, 24 Mar 2022 20:42:54 -0700 Message-Id: <20220325034253.2639930-3-kevinb@redhat.com> In-Reply-To: <20220325034253.2639930-1-kevinb@redhat.com> References: <20220325034253.2639930-1-kevinb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2022 03:44:31 -0000 This commit adds a new test case for bug 27831. See the contents of the .exp file for a description of what it's about. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=27831 --- .../gdb.base/add-symbol-file-attach.c | 28 ++++++ .../gdb.base/add-symbol-file-attach.exp | 88 +++++++++++++++++++ 2 files changed, 116 insertions(+) create mode 100644 gdb/testsuite/gdb.base/add-symbol-file-attach.c create mode 100644 gdb/testsuite/gdb.base/add-symbol-file-attach.exp diff --git a/gdb/testsuite/gdb.base/add-symbol-file-attach.c b/gdb/testsuite/gdb.base/add-symbol-file-attach.c new file mode 100644 index 00000000000..79c0362ff4b --- /dev/null +++ b/gdb/testsuite/gdb.base/add-symbol-file-attach.c @@ -0,0 +1,28 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2021-2022 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +#include +#include + +volatile int foo = 42; + +int +main (int argc, char **argv) +{ + pause (); + return 0; +} diff --git a/gdb/testsuite/gdb.base/add-symbol-file-attach.exp b/gdb/testsuite/gdb.base/add-symbol-file-attach.exp new file mode 100644 index 00000000000..dcc99a3e8a7 --- /dev/null +++ b/gdb/testsuite/gdb.base/add-symbol-file-attach.exp @@ -0,0 +1,88 @@ +# Copyright (C) 2021-2022 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# This is a test case for bug 27831: +# +# https://sourceware.org/bugzilla/show_bug.cgi?id=27831 +# +# Prior to fixing this bug, GDB could be caused to assert by doing +# the following: A simple program with a global was started outside +# of GDB. Once GDB was started, the symbol file was loaded in an +# atypical manner via the 'add-symbol-file' command. Then, the +# program was attached to via the 'attach' command at which time the +# symbol file was loaded again. Once attached, printing the global +# variable in the program would trigger the assertion error. +# +# This is what the assert looked like: +# +# gdb/symtab.c:6599: internal-error: get_msymbol_address: +# Assertion `(objf->flags & OBJF_MAINLINE) == 0' failed. + +if {![can_spawn_for_attach]} { + return 0 +} + +standard_testfile + +if [get_compiler_info] { + return -1 +} + +if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { + untested "failed to compile" + return -1 +} + +# Use 'spawn_wait_for_attach' to start the test program running. It'll +# also sleep for a short time in order to make sure that it's running +# so that GDB may attach to it. + +set test_spawn_id [spawn_wait_for_attach $binfile] +set testpid [spawn_id_get_pid $test_spawn_id] + +gdb_start + +# Load the symbol file in an atypical manner by using the add-symbol-file +# command. + +set test "add-symbol-file before attach" +gdb_test_multiple "add-symbol-file $binfile" $test { + -re "add symbol table from file.*y or n. $" { + send_gdb "y\n" + exp_continue + } + -re "Reading symbols from.*" { + pass $test + } +} + +# Attach to the process started above. GDB will want to load a "new" +# symbol table, so handle that case. + +set test "attach" +gdb_test_multiple "attach $testpid" $test { + -re "Attaching to process.*Load new symbol table.*y or n. $" { + send_gdb "y\n" + exp_continue + } + -re ".*in \[_A-Za-z0-9\]*pause.*$gdb_prompt $" { + pass $test + } +} + +# Print out the value of the global. Prior to fixing bug 27831, GDB +# would assert while executing this command. + +gdb_test "print foo" "42" -- 2.35.1