[PATCH] gdb/testsuite: fix timeout in server-pipe.exp test

[PATCH] gdb/testsuite: fix timeout in server-pipe.exp test

[Andrew Burgess]

I noticed that the gdb.server/server-pipe.exp test would sometimes
timeout when my machine was more heavily loaded.  Turns out the test
is reading all the shared libraries over GDB's remote protocol, which
can be slow.

We avoid this in other tests by setting the sysroot in GDBFLAGS,
something which is missing from the gdb.server/server-pipe.exp test.

Fix the timeouts by setting sysroot in GDBFLAGS, after this the shared
libraries are no longer copied over the remote protocol, and I no
longer see the test timeout.
---
 gdb/testsuite/gdb.server/server-pipe.exp | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/gdb.server/server-pipe.exp b/gdb/testsuite/gdb.server/server-pipe.exp
index ca2164b03e5..83537378aa6 100644
--- a/gdb/testsuite/gdb.server/server-pipe.exp
+++ b/gdb/testsuite/gdb.server/server-pipe.exp
@@ -74,7 +74,11 @@ proc do_test { target } {
     }
 }
 
-# Test with the two remote protocol types.
-foreach_with_prefix target { remote extended-remote } {
-    do_test ${target}
+save_vars { GDBFLAGS } {
+    set GDBFLAGS "$GDBFLAGS -ex \"set sysroot\""
+
+    # Test with the two remote protocol types.
+    foreach_with_prefix target { remote extended-remote } {
+	do_test ${target}
+    }
 }
-- 
2.25.4

Re: [PATCH] gdb/testsuite: fix timeout in server-pipe.exp test

[Tom Tromey]

>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> I noticed that the gdb.server/server-pipe.exp test would sometimes
Andrew> timeout when my machine was more heavily loaded.  Turns out the test
Andrew> is reading all the shared libraries over GDB's remote protocol, which
Andrew> can be slow.

Andrew> We avoid this in other tests by setting the sysroot in GDBFLAGS,
Andrew> something which is missing from the gdb.server/server-pipe.exp test.

Andrew> Fix the timeouts by setting sysroot in GDBFLAGS, after this the shared
Andrew> libraries are no longer copied over the remote protocol, and I no
Andrew> longer see the test timeout.

Seems good to me.  Thank you.

Tom

Re: [PATCH] gdb/testsuite: fix timeout in server-pipe.exp test

[Andrew Burgess]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> I noticed that the gdb.server/server-pipe.exp test would sometimes
> Andrew> timeout when my machine was more heavily loaded.  Turns out the test
> Andrew> is reading all the shared libraries over GDB's remote protocol, which
> Andrew> can be slow.
>
> Andrew> We avoid this in other tests by setting the sysroot in GDBFLAGS,
> Andrew> something which is missing from the gdb.server/server-pipe.exp test.
>
> Andrew> Fix the timeouts by setting sysroot in GDBFLAGS, after this the shared
> Andrew> libraries are no longer copied over the remote protocol, and I no
> Andrew> longer see the test timeout.
>
> Seems good to me.  Thank you.

Thanks, pushed.

Andrew