From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2051.outbound.protection.outlook.com [40.107.223.51]) by sourceware.org (Postfix) with ESMTPS id D1B5B3858D37 for ; Tue, 5 Apr 2022 10:04:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D1B5B3858D37 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I3QCg9c7DHLdj2Am/HZeWP6ReTveNUyYiy3t+xxjyvqx/sp2zXS739MfGU5kgBf6KRO/lYFlYuvoWSAKg/wvjmO9cg9ejkdOqLKn3XilvkDSRQRZjHjTeFn5jp/9ZV7kAGpVnbLTCCZiy7CD23RgcL5S0XixeXpdpUFgAo0Tyvhdg0NtyA8XqEETyJ4g0Tfj3xgVhsBPaoTKvPjdopKMAlu1VuS+zGREOgiAqEz5g3OIpOzoN2RHRiX7QPiJbS6gRWrwArWXZdK16DxysWvl4J1tV9eQHRr2cXYjh6btGBJHURM2wFE5ojDctdSHvwS9a2nxNciKpsjMy9mI6dkFJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xHC3ukqUKFE8tbjK7062Fw4nH7L8ZMdzPTu4ksDdnOI=; b=jJeRxz116PdrhGb1SPXkm5H3yvsadH66r1WGsvj58pkAkmlvBI8FPo8c5VxQkbxFj7hvdE7+lF3Nv9Hw+nBVHq/yhxq2PWTK8vXtPQT/Y6lXzcNjJ4E1KdkhIANUuY/JaASyXxokL34qauQJBVfsuopHWLYIkFhoNiJ1j4ogFCWHqt88sOW4K5k4o/j5jBElJ15F3eMROlIDZsQ7/g82ViPM1Q7/OEJDESbEEHJhRex+5BQmk1tcyl9cal0c+qtCbKkyXZ/YTr0RBmZ1XDNR/P1RYVusQBoznVvkySznTNdg4tywvOvPc3cyMBlwcLJHsZbeI9tTCh4HgVDfPBlWUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labware.com; dmarc=pass action=none header.from=labware.com; dkim=pass header.d=labware.com; arc=none Received: from DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) by BN6PR17MB1587.namprd17.prod.outlook.com (2603:10b6:404:12c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Tue, 5 Apr 2022 10:04:47 +0000 Received: from DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::3142:b93f:5fb9:dcc5]) by DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::3142:b93f:5fb9:dcc5%3]) with mapi id 15.20.5123.031; Tue, 5 Apr 2022 10:04:47 +0000 From: Jan Vrany To: gdb-patches@sourceware.org Cc: Jan Vrany Subject: [PATCH] gdb: skip objfiles with no BFD in DWARF unwinder Date: Tue, 5 Apr 2022 12:04:29 +0200 Message-Id: <20220405100429.188136-1-jan.vrany@labware.com> X-Mailer: git-send-email 2.35.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: VI1P194CA0053.EURP194.PROD.OUTLOOK.COM (2603:10a6:803:3c::42) To DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8c631bb8-bf54-4e4d-4313-08da16ebb719 X-MS-TrafficTypeDiagnostic: BN6PR17MB1587:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F5BAu+2MbnPA9W2k3AcWAiBTrFxuoY3P2oHo4RyoXUCI3Jtz+L/dKexVplgYZ3dZaC98Nj/yxjJFwTIq6H709vO+Sc3jyGAdiw9Cr2Ft9UB3potcMoOZaMXO29X902RFMOkRg6o/RhY8MK3esife938/F6Cwy1K5fsUtJKsAr5Vx2Ab2VBS2QK0fthwCIMytgVliNK3+SKpWjMDYcEMN29PC9BCYQmflxzAUPn0RZwRI5QhMud1QEqE0mZW0h7akl7GgfFgDyZVA9lz+ZU4qGfFstnldv26cziyIHnQxaQ4Fh7RvLLszHBgMUjdzov5AYKSGVDduT5ub/+AkwWc6LGVKZZBintIdYuBGdVaQm4agwCp3cjpiTf5LUlfAY9nc+9x2sKhGjuo/F7yRgcKbUoW/RdAWOR1hj/FqTC84nesjInIMp3zjb/kymYNE4iupImH1BPpvFvFCzRRmXDuZyvJWY+/bQfnaAkoFFJUlCqLlKyZ0+E+1Aqvj7Sclt9eRsqzJjM6op8fPnof/OHdSLT3r3QzZvMHGaqMMPDP/0SZbwin1ofcUVfT9gi+TgWgiwsOInC2uSNBmpo9sx5w4iyUgMqkPejJZ03N0FSbKgUqKrIwtLxi0mulmH4huKLyIP9YE9O4+mdKzW3NRLWmobzCbnLEcwO0I2hzPILi0gkTWnCrVn+aKEe5KcfqQHUnX84DGtcpuY9Vv1jAGfD6LkQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR17MB3113.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66946007)(107886003)(6512007)(6666004)(52116002)(5660300002)(4326008)(36756003)(83380400001)(66476007)(66556008)(8676002)(86362001)(26005)(186003)(6486002)(8936002)(2616005)(1076003)(38350700002)(6916009)(38100700002)(44832011)(316002)(6506007)(2906002)(508600001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2Sh6HAiO1Y30B49LYQar4/yV8rfhrv2n5V/QzhApUc4pR9yDMSEE8NwLtar6?= =?us-ascii?Q?HixMbR9IWxV5Tc/KAHF7F7D9FaBJwBRKc5XW1hxHY+dyuAa1H/h+lLtKUMGd?= =?us-ascii?Q?PgI0Xx8ep9C/JLdv2ndkqLIDsLxKz+2knOCws6kYsmPj/VKuo+rG0moY3xMK?= =?us-ascii?Q?JYHYwcOQum5nAeD1bjdQsIi4wheXYmXvPY3sxjS6P5F/IAw/WWekI+nCEZvd?= =?us-ascii?Q?9wPZY8fGG66p1A+ofmLQbB8RAaq8xVRYPSvB4Ke5cUjlB2G9SjulQdAXS6jY?= =?us-ascii?Q?vLjbTSaAsm78qukVXWiRpbitf7tDLSme65DjTAXtGykVBDeVwSwD3+lSrYb2?= =?us-ascii?Q?dmSxJtOQPZfW+t8jH80D+YCt3shRdV2TPwJuxiSnWHmzZcAo55+rWZ9XApjm?= =?us-ascii?Q?4bL52wcyI4iM/Q/890U6LJ2zRE7jDTiti0qSNWV+rZMzzSEGCWCOs2fdLLgb?= =?us-ascii?Q?ymFCvB3OpBmU+TyuKEVFZdM7WIdKuYnBdlibz2sLk5Tw0OftiT9VcwbpbGf/?= =?us-ascii?Q?TWz7d+SS01tOdegzOWjsT5l3AlMbTIwTN+hjkUUWttw9v87E1oAzL4OcBJYm?= =?us-ascii?Q?1CBdq9JK9t2aB5T8NV3WGqPSt57K6+Us33pXdfQdnOzbtQfp5SHKs3K1EDIL?= =?us-ascii?Q?wsiBOUnIhmfAqKi4IQ5EV5LDZ62QHVADRbLT714hLvtfeQR9fayBSTuXsIOY?= =?us-ascii?Q?bJPrv/zEDVZ+FHIjlgvWY50akrMDfSOuAuMSHgKfFXVHO/Phh2csE/kGThue?= =?us-ascii?Q?Xb2zjIWg9RWnZhj3ZMnLYm8Tfo958rHDSFSaczJ3MWpNk88mbwDsP3cUH59H?= =?us-ascii?Q?6DbrEw2d4P0DySj7tnJLHUqttRq9N2Vh37CVFuTmoCxCjBlz+TR9F/b0jgH5?= =?us-ascii?Q?qfjyodEecDshmkWiY4d+NzogE6U5f/VrHB163Cau/o8JNYbcpB7i2MkX7LNr?= =?us-ascii?Q?36oVvlwe52aVdxRXf9mYjbXZIXc7VUCnS+SH03TueMD8g8XUyweKq5GqGG+i?= =?us-ascii?Q?nay2OnLMkC89zWS+0qiBqVc/hgDXxhLwrxOFOnSxmSgEi02FYGr2QKJCZqdf?= =?us-ascii?Q?dt299EFtO5UvLuo5h7Kr9SNLh71lQ6neANFzaE4aM1650E0OMUa/06aJV8Ap?= =?us-ascii?Q?NP87iBox/GLKO4ZRNfnrBt/ZYGdlJZEYmu2HIxYpiO5b++RbrNUtXsiatUvE?= =?us-ascii?Q?4PI7s5mgrk8ig4rJqO9cFKwD0K/teZTZZ6Qy0ttx7IweZ+3UzrQPev1X1mXe?= =?us-ascii?Q?aykRE8ceGiRTKuzjseb+hschH4ufHCl52P4F1Ak3qhJg4GkfgR3eEBRVxFFA?= =?us-ascii?Q?BQ4UzoaSwEbq6VoUhWhoIonqTCv4t9LbwqC9ClUWXMGO2nLBbCGOZsqL1ReG?= =?us-ascii?Q?kGBLrfSHnIMQJ6Ciy4vy/8YAv+ishTsjCJJeIzzIhjJzZx7sWEnZB/FCKnOP?= =?us-ascii?Q?pjT24G1fjh0a0Uce/a6AoSkOUSh6ZkIE9oC5qyGe1d5EmdMOvbcf6eNY5UmN?= =?us-ascii?Q?Fwgxa4OikVKwnS58NxTrOJEvkPa7kvLki9XlKUv8Sqdk8lvwTGUcQDIz/73Z?= =?us-ascii?Q?SAdJ7+P/GFFdQKMPFZkEacG5HzwLuJ9EjXSOQ8WPKDziXgTUP20jBhzMQIdV?= =?us-ascii?Q?RbrJpXcnPBsuv2k37Cm5XXs3JoLV3ZyDWIyQv0WSaOlo28fvtePygAM2Fh2+?= =?us-ascii?Q?dAwDiHP+3wvDquv9gtAKHMRppxZ9tjmeTArBYFxUlWiCHuLJOAwCoP4vbihv?= =?us-ascii?Q?cmbDFdPwSg=3D=3D?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c631bb8-bf54-4e4d-4313-08da16ebb719 X-MS-Exchange-CrossTenant-AuthSource: DM6PR17MB3113.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2022 10:04:47.3076 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RiPkXYll1F8JytHOIRPOCrgJ5EWCYhsDmIftwLhTMK5ReX+eP2KiZO6NedNil0qHjTgEYASuv0KnaC1ILhUQwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR17MB1587 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2022 10:04:52 -0000 While playing with JIT reader I experienced GDB to crash on null-pointer dereference when stepping through non-jitted code. The problem was that dwarf2_frame_find_fde () assumed that all objfiles have BFD but that's not always true. To address this problem, this commit skips such objfiles. As for the test, I initially tried to use temporary breakpoint and then 'continue' to get out of the jitted code but this for some reason did not trigger the crash. Using 'finish' to get out of jitted code followed by 'next' triggered it. --- gdb/dwarf2/frame.c | 3 +++ gdb/objfiles.h | 4 +++- gdb/testsuite/gdb.base/jit-reader.exp | 10 ++++++++++ 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/gdb/dwarf2/frame.c b/gdb/dwarf2/frame.c index 5878d72f922..514ae8c694f 100644 --- a/gdb/dwarf2/frame.c +++ b/gdb/dwarf2/frame.c @@ -1565,6 +1565,9 @@ dwarf2_frame_find_fde (CORE_ADDR *pc, dwarf2_per_objfile **out_per_objfile) CORE_ADDR offset; CORE_ADDR seek_pc; + if (objfile->obfd == nullptr) + continue; + comp_unit *unit = find_comp_unit (objfile); if (unit == NULL) { diff --git a/gdb/objfiles.h b/gdb/objfiles.h index 8bd76705688..429dea1da4c 100644 --- a/gdb/objfiles.h +++ b/gdb/objfiles.h @@ -636,7 +636,9 @@ struct objfile struct compunit_symtab *compunit_symtabs = nullptr; /* The object file's BFD. Can be null if the objfile contains only - minimal symbols, e.g. the run time common symbols for SunOS4. */ + minimal symbols (e.g. the run time common symbols for SunOS4) or + if the objfile is a dynamic objfile (e.g. created by JIT reader + API). */ bfd *obfd; diff --git a/gdb/testsuite/gdb.base/jit-reader.exp b/gdb/testsuite/gdb.base/jit-reader.exp index d94360cd7d9..0de552b1ce5 100644 --- a/gdb/testsuite/gdb.base/jit-reader.exp +++ b/gdb/testsuite/gdb.base/jit-reader.exp @@ -271,6 +271,16 @@ proc jit_reader_test {} { "#1 ${any} in main ${any}" \ ] } + + # check that the DWARF unwinder does not crash in presence of + # JIT objfiles. + gdb_test "fin" \ + [multi_line \ + "Run till exit from ${any} jit_function_stack_mangle ${any}" \ + "main ${any} at ${any}.*" \ + ] + gdb_test "bt" "#0 main ${any} at ${any}" + gdb_test "next" } jit_reader_test -- 2.35.1