From: Lancelot SIX <lsix@lancelotsix.com>
To: Jan Vrany <jan.vrany@labware.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: skip objfiles with no BFD in DWARF unwinder
Date: Tue, 5 Apr 2022 14:19:17 +0000 [thread overview]
Message-ID: <20220405141802.axq5dwhxc3iyfkmz@ubuntu> (raw)
In-Reply-To: <20220405100429.188136-1-jan.vrany@labware.com>
Hi,
> diff --git a/gdb/testsuite/gdb.base/jit-reader.exp b/gdb/testsuite/gdb.base/jit-reader.exp
> index d94360cd7d9..0de552b1ce5 100644
> --- a/gdb/testsuite/gdb.base/jit-reader.exp
> +++ b/gdb/testsuite/gdb.base/jit-reader.exp
> @@ -271,6 +271,16 @@ proc jit_reader_test {} {
> "#1 ${any} in main ${any}" \
> ]
> }
> +
> + # check that the DWARF unwinder does not crash in presence of
> + # JIT objfiles.
> + gdb_test "fin" \
> + [multi_line \
> + "Run till exit from ${any} jit_function_stack_mangle ${any}" \
> + "main ${any} at ${any}.*" \
> + ]
> + gdb_test "bt" "#0 main ${any} at ${any}"
> + gdb_test "next"
> }
The tests above use with_test_prefix to create logical blocks. You
probably want to wrap what you just added in a similar construct. This
is for consistency, it creates .sum/.log files easier to work with and
also if one wants to add other commands just below those one, we do not
risk having DUPLICATE test names.
Best,
Lancelot.
next prev parent reply other threads:[~2022-04-05 14:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 10:04 Jan Vrany
2022-04-05 14:19 ` Lancelot SIX [this message]
2022-04-05 14:46 ` Simon Marchi
2022-04-06 17:50 ` Jan Vrany
2022-04-05 19:08 ` Pedro Alves
2022-04-06 18:06 ` Jan Vrany
2022-04-06 18:55 ` [PATCH v2] " Jan Vrany
2022-12-07 11:07 ` Jan Vraný
2022-12-07 16:07 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405141802.axq5dwhxc3iyfkmz@ubuntu \
--to=lsix@lancelotsix.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.vrany@labware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).