From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from barracuda.ebox.ca (barracuda.ebox.ca [96.127.255.19]) by sourceware.org (Postfix) with ESMTPS id C61493864C15 for ; Wed, 6 Apr 2022 14:42:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C61493864C15 X-ASG-Debug-ID: 1649256126-0c856e06abae93d0001-fS2M51 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id w977uCBVZ1scNDgu (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 06 Apr 2022 10:42:06 -0400 (EDT) X-Barracuda-Envelope-From: simon.marchi@polymtl.ca X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from simark.localdomain (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) by smtp.ebox.ca (Postfix) with ESMTP id 9984B441B21; Wed, 6 Apr 2022 10:42:06 -0400 (EDT) From: Simon Marchi X-Barracuda-RBL-IP: 192.222.157.6 X-Barracuda-Effective-Source-IP: 192-222-157-6.qc.cable.ebox.net[192.222.157.6] X-Barracuda-Apparent-Source-IP: 192.222.157.6 To: gdb-patches@sourceware.org Subject: [PATCH 0/4] Remove some symtab accessors Date: Wed, 6 Apr 2022 10:42:01 -0400 X-ASG-Orig-Subj: [PATCH 0/4] Remove some symtab accessors Message-Id: <20220406144205.1415376-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Barracuda-Connect: smtp.ebox.ca[96.127.255.82] X-Barracuda-Start-Time: 1649256126 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Barracuda-BRTS-Status: 1 X-Virus-Scanned: by bsmtpd at ebox.ca X-Barracuda-Scan-Msg-Size: 1755 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.97169 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Spam-Status: No, score=-3607.0 required=5.0 tests=BAYES_00, KAM_DMARC_QUARANTINE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 14:42:18 -0000 I am playing with symtabs currently and was a bit confused with some accessors that make some things appear as if they are symtab-specific, when they are not. These accessors forward to the symtab's parent objects. I don't think they are very useful and just hide the real object structure of GDB, so I suggest removing them. Simon Marchi (4): gdb: remove symtab::dirname gdb: remove symtab::blockvector gdb: remove symtab::objfile gdb: remove symtab::pspace gdb/ada-exp.y | 3 +- gdb/ada-lang.c | 8 ++-- gdb/annotate.c | 4 +- gdb/breakpoint.c | 9 +++-- gdb/c-exp.y | 5 ++- gdb/cli/cli-cmds.c | 8 ++-- gdb/coffread.c | 2 +- gdb/compile/compile-object-load.c | 2 +- gdb/compile/compile.c | 2 +- gdb/guile/scm-symtab.c | 12 +++--- gdb/linespec.c | 63 ++++++++++++++++++------------- gdb/mdebugread.c | 16 ++++---- gdb/mi/mi-symbol-cmds.c | 2 +- gdb/objfiles.c | 2 +- gdb/p-exp.y | 5 ++- gdb/parse.c | 2 +- gdb/python/py-symtab.c | 24 ++++++------ gdb/source-cache.c | 5 ++- gdb/source.c | 19 +++++----- gdb/symmisc.c | 10 ++--- gdb/symtab.c | 14 ++----- gdb/symtab.h | 26 ------------- gdb/tui/tui-source.c | 2 +- gdb/tui/tui-winsource.c | 2 +- 24 files changed, 116 insertions(+), 131 deletions(-) base-commit: 7fb56b98937a2feef5a3e12d8b00506ff4d132be -- 2.35.1