From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2044.outbound.protection.outlook.com [40.107.96.44]) by sourceware.org (Postfix) with ESMTPS id 0F1643858D28 for ; Wed, 6 Apr 2022 18:56:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0F1643858D28 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E9Q/jBkP5zcZ9WeSrJMWSUOcah/nYzIjsnoh/3Bo2mX7FH6mTv43VnZU+048EDSVtaLg6U2M5VI+fXSaKqH53xX2Ge3koK26DC+aQNYLyY/skIZiXC8eDRbH9E9pwHcc4YLYnEWATm5ShjGC2YI9x+pjREc1hmVj5hW246GfQAWXvy0cK3ZdnZdR964sUegH8ztSJSYvTAFTnK7eBsaYhNE4IGe32LNrFyxAHk9sLOauoKd8HsZGVGGMbFDSdUnA3O1UOVgDIFN3UwCi3TZAd/vBMj/yd/xLWHDC0daz0NPN9NKPdMtFdS0blGdQ8EddicCnkQsIGsVwtLKYHYqiSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5larGBgNlQMlpfO11Zdu9uVJbV38rwobXc5SsUpxXm8=; b=OkY22/4eBRbcNH4zKOoFX75eEBesnIcIU4+GGakp5415Njq22/ofLMoiETCbITTrLFbeZL7mnPagdvYiKNr2fK2NuAQ/6TAyxMVwQcDNBLFritFQ1yYCNm9W94FwFZZfKrVuPPymY1hbm4U7GESYNMv1U8uPHo9NHnNJTMOM2OJaKna9D24ayrR9kI4KmiFMjd4vXA1dkqmnrJdjdJ8TNGLSPn8e9iLTNpDlMz0GhcT50n4RNTKPbh8Ved/+8dlyWCTT6ev3v4pgyJ0tlSYipKFv9uj9V3lrIX8uhBTO8GRuZaRWPWhM3opXYptNo2jP5qQg954DQsuHykC57c0igA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=labware.com; dmarc=pass action=none header.from=labware.com; dkim=pass header.d=labware.com; arc=none Received: from DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) by CY4PR17MB1174.namprd17.prod.outlook.com (2603:10b6:903:8f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Wed, 6 Apr 2022 18:55:59 +0000 Received: from DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::3142:b93f:5fb9:dcc5]) by DM6PR17MB3113.namprd17.prod.outlook.com ([fe80::3142:b93f:5fb9:dcc5%3]) with mapi id 15.20.5144.019; Wed, 6 Apr 2022 18:55:59 +0000 From: Jan Vrany To: gdb-patches@sourceware.org Cc: Jan Vrany Subject: [PATCH v2] gdb: skip objfiles with no BFD in DWARF unwinder Date: Wed, 6 Apr 2022 20:55:24 +0200 Message-Id: <20220406185524.30713-1-jan.vrany@labware.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <7b267fea-452e-446e-3800-1cbacd50b689@palves.net> References: <7b267fea-452e-446e-3800-1cbacd50b689@palves.net> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: VI1P189CA0019.EURP189.PROD.OUTLOOK.COM (2603:10a6:802:2a::32) To DM6PR17MB3113.namprd17.prod.outlook.com (2603:10b6:5:6::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b3f615bc-9209-4a4a-eb6f-08da17ff16b4 X-MS-TrafficTypeDiagnostic: CY4PR17MB1174:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kx8lv9pY/0kS+kcXa73vyeQSF/8N4CPXVk1ACUcqhfE3YAVgPQujyRR/0H1949+qYF3hOuLAiONYGgQZAubnr3Kt4RpNO1PEWzX5x00UZi10QWfTnSCLf3ydpUbIbH/UjHLcf2I83ST9G0iQOfPFhTeb4zrL7U0p0IqFJSbvKpCzLN5Sy90mdkb/5FTw3R1lxMSazmWFMlXs6E0pJmLJUWmJf0/+bj5pPzWUk7w3JmUAc1TXWKrXSAufhrZJMiOEoBzy59JgTMAMg8pTBBKR+N8wUakMk0TgmgY1uBlPbsuiMY5/AU7OCEt+VHp6fvBSDOFUoTzWPSOuMdvOYBmgTqNwZZAnCYwvyxgMliTSKR5r9p3ZorLw/YFHY4fkCU11r9c3B7ib1FxqSHNy/Fjpr/wj3D366aldJrcD4Y5SO5Ttp4xRjcoit1zrRXTifcX3eznnWguATcDvxLzxYriHoPGYzVtNZTDuO1ELt/7f39X63IN7+dB+D0CfPwtBbOjohzQ2XY7qDfdIA3d0dz4GPEckQKjp41Rw0zvx4yiBQuyviX7XB1pcZLFNX9Db/sb/SZip4ahnw1fIzO/GQGHzpawOLs2EklsXlAKL02crSG9QUIrzT7WvoYHn6w4PLvvBLXYAa3cRPQWyIjBzZgSiKHnadAW6WcK0iFzzzn+hP3pVAVocwL0juAAGbpnNph6QrLRQL7KT+hNCdU2x5Fxr+w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR17MB3113.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(44832011)(38350700002)(38100700002)(2906002)(4326008)(8676002)(5660300002)(8936002)(66476007)(66946007)(186003)(83380400001)(316002)(1076003)(2616005)(86362001)(107886003)(6506007)(66556008)(6916009)(36756003)(26005)(6666004)(6512007)(52116002)(508600001)(6486002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KFOMX7fJpMyBQ0a9w5wZ+bfNMf+3d5gkYDsNQS2WPJa1dKyYjEr5vQQ/6ufN?= =?us-ascii?Q?4MjsPrd1gx1x7k4AhAEwNskfpGXe8RR7GvvLGKxtaB+giZ43O/kcL0LkidGh?= =?us-ascii?Q?YcnYLVqtU+7jXlBmZF5ss+CeMqwl9QKgKzXEyxDL/dYUH8LiVfOGNujvTEKR?= =?us-ascii?Q?5xP2lXI9aWWOsotu6Ku3qt3ZuBhQmxh6YUWA4FkJoZDmDTzuGA6WB0VVfwa8?= =?us-ascii?Q?ourF0iMcxo2WVlkcoEMgKYdFQz+2P2sdLGuOY6sNjBbsxJ012+cc2W37nPgM?= =?us-ascii?Q?5wKSCfOfqkb+hyCI7V8Rqt/vKuqcHm6ZRid6YS7COBo/8ORE2VMaddHA1dTp?= =?us-ascii?Q?ffmRsuA+/U57Nwj6X9ef6s7D7YLGud4ANmLgIiMhwBmwOdJghwMkn99nGmrU?= =?us-ascii?Q?i/DiLBwn2RpdZ1//njYroBG7AQi2bP6OjHi7fxu3Qc+c47x7/OW4u1v+XizM?= =?us-ascii?Q?44Ook3TZeW2O/poo4PuBnTX7jJNJ9MDerT0rKTCR30sMRBqbAxLWuJ6Sk9gP?= =?us-ascii?Q?oO4J+zghXVPMa4x59+eKnmqvqqX1d+Fz0AKHHrHDCKMMTtSH8YNEusZoawRN?= =?us-ascii?Q?gLluQNkgpbNQGQ+fyCf0vqQEjrRIXGSQKax4YuneuLqa0fa8k9h6YF3vItzx?= =?us-ascii?Q?vCDq/jHwRRwtjSoYFkaFHvqkdac4nihf78M2Go30/rOK/YFfvMJYdXTKljkR?= =?us-ascii?Q?jcyizoDFXLqPoqQ3zz5eEzlXd+1uRPZ04d3MSwHPo+G3dDgQXtMutFbHrZSC?= =?us-ascii?Q?jsZO0Ahhen/rVkPe3ORHPPpmexNLW0ETmEfq6I+UvdyG8HnhLMAZIm/wGQ5f?= =?us-ascii?Q?eHLBhiyZw6a09Y/y5NiaJoft4mnJhgf7gInCiDEe0cFAhc0bQn4JjmUHxTbW?= =?us-ascii?Q?No+RSmWE5hAb+4W/ZUX1y5Q9Jf1WLLOWswMlUqMQAOJLS4JCuJNXvjPTq++4?= =?us-ascii?Q?fZ23SRnaR0CDVEQvRiS5FVhtgI/c1i4o22fuhO7lT8QGqZOiBr+YXZcJ1hHp?= =?us-ascii?Q?g9r9NdX7scPq3M2VPIutCNO9kwJZJgn+6TDqB26pBlEMUWjiXEtwwCOcue5n?= =?us-ascii?Q?OhrB4vdLaZx2bJq4jETk15/QMkGk+O3t6zTDsO1B+aUqgi78cPlr1722zemG?= =?us-ascii?Q?Gcsz0/hmkn1vZhf4OeaDpDsSKlsqzV3m94Ot74gHWWzKvifNVpsO1qs10mmT?= =?us-ascii?Q?5NVeZ+UUM76MwHP3j9LCr+SfFrDVY7uCNmp9w2GSqjubEsFxMO9ZNU5ZtG28?= =?us-ascii?Q?d0JfEpAv5IMvoNr25oraizrxS1WzoEwdeTtdAEXht0lvHytlznuIJvd8+90A?= =?us-ascii?Q?UGmAHyUrqicbtrWULMqfqQJU3ZeJllL80TB4mQWsXQ4LXdAB3NfAwg/rzWS6?= =?us-ascii?Q?hhZTEEGrfYU9tR9wErxUqH8hha91VrUVeGM/IdK6YityMqSBIiVDhNbbrgNC?= =?us-ascii?Q?h8jakZA5lxU3sJNnJ3MYf4paf4d9vhEG5F2vsuK3ESFDiU3oBx5ws5JweR66?= =?us-ascii?Q?KWiN51AuqXBPMsKNgsakwVl9Co9doQPgMwe7nNtDPvePm7qTu34VGhzhRF46?= =?us-ascii?Q?xcXK81mpvX3jnWUAgfKLvIm5JrpA8ZOwbvxt1hPYIxM5fWY64DXaLgJfC4dN?= =?us-ascii?Q?8KdUQCunxLRzkvA8kj6N+0bRuYjTEJKZrEAgyePpGQAW18Vs86BM2Ioxl22j?= =?us-ascii?Q?97yQ72LyXASG2I82hy7/GDMeiHLm9kSAVktaZyWMsfRpQG5vziATZxvideto?= =?us-ascii?Q?2Dv1x1faDQ=3D=3D?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3f615bc-9209-4a4a-eb6f-08da17ff16b4 X-MS-Exchange-CrossTenant-AuthSource: DM6PR17MB3113.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2022 18:55:59.4369 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JetleaVq17hiQandc45+1uLgae55wWoT23fg49GsycRY9uhlVkgQrbRqnFef+hKtGox3TdaoM9ks3s077Ekyvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR17MB1174 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 18:56:06 -0000 Changes since v1: * use with_test_prefix as Lancelot suggested * rewrote test as Pedro suggested * updated commit message -- >8 -- While playing with JIT reader I experienced GDB to crash on null-pointer dereference when stepping through non-jitted code. The problem was that dwarf2_frame_find_fde () assumed that all objfiles have BFD but that's not always true. To address this problem, this commit skips such objfiles. To test the fix we put breakpoint in jit_function_add (). The JIT reader does not know how unwind this function so unwinding eventually falls back to DWARF unwinder which in turn iterates over objfiles. Since the the code is jitted, it is guaranteed it would eventually process JIT objfile. --- gdb/dwarf2/frame.c | 3 +++ gdb/objfiles.h | 4 +++- gdb/testsuite/gdb.base/jit-reader.exp | 13 +++++++++++++ 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/gdb/dwarf2/frame.c b/gdb/dwarf2/frame.c index 5878d72f922..514ae8c694f 100644 --- a/gdb/dwarf2/frame.c +++ b/gdb/dwarf2/frame.c @@ -1565,6 +1565,9 @@ dwarf2_frame_find_fde (CORE_ADDR *pc, dwarf2_per_objfile **out_per_objfile) CORE_ADDR offset; CORE_ADDR seek_pc; + if (objfile->obfd == nullptr) + continue; + comp_unit *unit = find_comp_unit (objfile); if (unit == NULL) { diff --git a/gdb/objfiles.h b/gdb/objfiles.h index 8bd76705688..429dea1da4c 100644 --- a/gdb/objfiles.h +++ b/gdb/objfiles.h @@ -636,7 +636,9 @@ struct objfile struct compunit_symtab *compunit_symtabs = nullptr; /* The object file's BFD. Can be null if the objfile contains only - minimal symbols, e.g. the run time common symbols for SunOS4. */ + minimal symbols (e.g. the run time common symbols for SunOS4) or + if the objfile is a dynamic objfile (e.g. created by JIT reader + API). */ bfd *obfd; diff --git a/gdb/testsuite/gdb.base/jit-reader.exp b/gdb/testsuite/gdb.base/jit-reader.exp index d94360cd7d9..756b400906c 100644 --- a/gdb/testsuite/gdb.base/jit-reader.exp +++ b/gdb/testsuite/gdb.base/jit-reader.exp @@ -271,6 +271,19 @@ proc jit_reader_test {} { "#1 ${any} in main ${any}" \ ] } + + with_test_prefix "test dwarf unwinder" { + # Check that the DWARF unwinder does not crash in presence of + # JIT objfiles. + gdb_test "up" + gdb_breakpoint "*function_add" temporary + gdb_test "cont" ".*Temporary breakpoint ${any} in jit_function_add .*" + gdb_test "bt" \ + [multi_line \ + "#0 ${any} in jit_function_add ${any}" \ + "#1 ${any} in main ${any}" \ + ] + } } jit_reader_test -- 2.35.1