[PATCH 1/4] Switch order of comparison in some spots

[Tom Tromey <tom@tromey.com>]

In the smart wrapper for "frame_info *", I've implemented the
comparison operators as members.  This means that they are
order-dependent -- "x == NULL" works, but "NULL == x" does not.

I don't consider this a big deal, since the former is the normal
spelling anyway.  And, when building GDB, it only affected three
spots, fixed here.

It would be possible to reimplement these operators outside the class,
to allow both orders, if someone feels this is important.
---
 gdb/or1k-tdep.c             | 2 +-
 gdb/python/py-framefilter.c | 2 +-
 gdb/s12z-tdep.c             | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/or1k-tdep.c b/gdb/or1k-tdep.c
index 2b906fa69d3..6d5cc244dae 100644
--- a/gdb/or1k-tdep.c
+++ b/gdb/or1k-tdep.c
@@ -923,7 +923,7 @@ or1k_frame_cache (struct frame_info *this_frame, void **prologue_cache)
 
   /* Get the stack pointer if we have one (if there's no process executing
      yet we won't have a frame.  */
-  this_sp = (NULL == this_frame) ? 0 :
+  this_sp = (this_frame == NULL) ? 0 :
     get_frame_register_unsigned (this_frame, OR1K_SP_REGNUM);
 
   /* Return early if GDB couldn't find the function.  */
diff --git a/gdb/python/py-framefilter.c b/gdb/python/py-framefilter.c
index 366f3745b9d..cc0d30db7dd 100644
--- a/gdb/python/py-framefilter.c
+++ b/gdb/python/py-framefilter.c
@@ -871,7 +871,7 @@ py_print_frame (PyObject *filter, frame_filter_flags flags,
 	 where elided synthetic dummy-frames have to 'borrow' the frame
 	 architecture from the eliding frame.  If that is the case, do
 	 not print 'level', but print spaces.  */
-      if (*slot == frame)
+      if (frame == *slot)
 	out->field_skip ("level");
       else
 	{
diff --git a/gdb/s12z-tdep.c b/gdb/s12z-tdep.c
index 5394c1bbf5e..fdcb3f76aa0 100644
--- a/gdb/s12z-tdep.c
+++ b/gdb/s12z-tdep.c
@@ -288,7 +288,7 @@ s12z_frame_cache (struct frame_info *this_frame, void **prologue_cache)
 
   /* Get the stack pointer if we have one (if there's no process executing
      yet we won't have a frame.  */
-  this_sp = (NULL == this_frame) ? 0 :
+  this_sp = (this_frame == NULL) ? 0 :
     get_frame_register_unsigned (this_frame, REG_S);
 
   /* Return early if GDB couldn't find the function.  */
-- 
2.34.1