From: Bruno Larsen <blarsen@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v2 10/11] gdb/testsuite: fix gdb.base/msym-bp-shl when running with Clang
Date: Mon, 11 Apr 2022 17:13:32 -0300 [thread overview]
Message-ID: <20220411201333.81453-11-blarsen@redhat.com> (raw)
In-Reply-To: <20220411201333.81453-1-blarsen@redhat.com>
Because Clang's -O0 is not as unoptimized as gcc's, one of the functions
of gdb.base/msym-bp-shl was being optimized away, making the entire test
fail. A lot of the test fail like so:
(gdb) break foo
Breakpoint 1 at 0x401030
(gdb) FAIL: gdb.base/msym-bp-shl.exp: debug=0: before run: break foo
info breakpoint
Num Type Disp Enb Address What
1 breakpoint keep y 0x0000000000401030 <foo@plt>
(gdb) FAIL: gdb.base/msym-bp-shl.exp: debug=0: before run: info breakpoint
As the test expects 2 breakpoints to be placed. This can't be easily fixed
by adding __attribute__ ((used)) to the function, since Clang will still
optimize away the function. Because of this, the test is skipped when
the it detects that Clang is being used
---
gdb/testsuite/gdb.base/msym-bp-shl.exp | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/gdb/testsuite/gdb.base/msym-bp-shl.exp b/gdb/testsuite/gdb.base/msym-bp-shl.exp
index 42adcb191dd..dd7d05bab52 100644
--- a/gdb/testsuite/gdb.base/msym-bp-shl.exp
+++ b/gdb/testsuite/gdb.base/msym-bp-shl.exp
@@ -22,6 +22,14 @@ if {[skip_shlib_tests]} {
return 0
}
+# Clang will optimize away the static foo, regardless of using
+# __attribute__((used)), so we'll always get a single breakpoint
+# making this test useless
+if {[test_compiler_info {clang-*-*}]} {
+ untested "Clang optimizes away one of the functions"
+ return
+}
+
standard_testfile msym-bp-shl-main.c msym-bp-shl-main-2.c msym-bp-shl-lib.c
set srcfile ${srcdir}/${subdir}/${srcfile}
set srcfile2 ${srcdir}/${subdir}/${srcfile2}
--
2.31.1
next prev parent reply other threads:[~2022-04-11 20:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 20:13 [PATCH v2 00/11] gdb/testsuite: Cleanup gdb.base for clang testing Bruno Larsen
2022-04-11 20:13 ` [PATCH v2 01/11] gdb/testsuite: introduce gdb_step_until_regexp Bruno Larsen
2022-04-11 20:13 ` [PATCH v2 02/11] Change gdb.base/skip-solib.exp deal with lack of epilogue information Bruno Larsen
2022-04-11 20:13 ` [PATCH v2 03/11] change gdb.base/skip.exp to use finish instead of step Bruno Larsen
2022-04-12 18:11 ` Bruno Larsen
2022-05-17 16:38 ` Bruno Larsen
2022-04-11 20:13 ` [PATCH v2 04/11] change gdb.base/symbol-alias to xfail with clang Bruno Larsen
2022-04-11 20:13 ` [PATCH v2 05/11] change gdb.base/nodebug.c to not fail " Bruno Larsen
2022-04-11 20:13 ` [PATCH v2 06/11] update gdb.base/info-program.exp " Bruno Larsen
2022-04-11 20:13 ` [PATCH v2 07/11] fix gdb.base/access-mem-running.exp for clang testing Bruno Larsen
2022-04-11 20:13 ` [PATCH v2 08/11] Fix gdb.base/call-ar-st to work with Clang Bruno Larsen
2022-04-11 20:13 ` [PATCH v2 09/11] add xfails to gdb.base/complex-parts.exp when testing with clang Bruno Larsen
2022-04-11 20:13 ` Bruno Larsen [this message]
2022-04-11 20:13 ` [PATCH v2 11/11] explicitly test for stderr in gdb.base/dprintf.exp Bruno Larsen
2022-04-26 13:17 ` [PING] [PATCH v2 00/11] gdb/testsuite: Cleanup gdb.base for clang testing Bruno Larsen
2022-05-03 20:43 ` [PINGv2] " Bruno Larsen
2022-05-10 20:06 ` [PINGv3] " Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220411201333.81453-11-blarsen@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).