From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by sourceware.org (Postfix) with ESMTPS id 16FE53857418 for ; Wed, 13 Apr 2022 19:18:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 16FE53857418 Received: by mail-io1-xd36.google.com with SMTP id p21so3027079ioj.4 for ; Wed, 13 Apr 2022 12:18:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TEZN142rLq0EwPcbg5e7//KU//MPj4dY6MzWdJ0rdxE=; b=Xvbl/uAAeVcl/UC5te7lT4R6EgZF6DW3YOLplpyIEmbwuf2NmtZGm3fL2/9w/rbHMa LG4eBVpGWTxKZ5MO1otfqLOHU9BbJSWUvwbcFCC+MQXeCuZQ4LcR07ExzrFxWWZtsc7z 3ZsBdOsNSwrogr8m+rtqs63imu1RRrfR5yu5ndyHcVtqmogTLhxW5+9RBkVmmJa3pFE5 pKCyRjd+hXNkfmGX9aUCgKrha73aiBCZaoIN74Vin15hD0Eqxh6Vajl+eFjQMxjS+Tj+ KxUuxKo84w1NAE8yusm6aJllucq7U6ZCJpzAR/o234S6mfMaI90paxaI0KIFsDo+epVa LmgA== X-Gm-Message-State: AOAM531H23iE9E7CMpqRGW3VmRvfDzLPnJooW/87pF7efo2JLwHEBWU2 cYigN9j8XZLY3ynKae32QjbU2q86x+cbBA== X-Google-Smtp-Source: ABdhPJzTv/VDApYkGbPYpLmtWHXDeI19WtHXl3glXX6CRy7lILFkIDMp4RAGwZR1EZqyxkeZIIsUtw== X-Received: by 2002:a05:6638:481a:b0:326:6a2c:2396 with SMTP id cp26-20020a056638481a00b003266a2c2396mr1922609jab.122.1649877480300; Wed, 13 Apr 2022 12:18:00 -0700 (PDT) Received: from murgatroyd.Home (71-211-154-204.hlrn.qwest.net. [71.211.154.204]) by smtp.gmail.com with ESMTPSA id e203-20020a6bb5d4000000b0064dafa0416fsm427660iof.2.2022.04.13.12.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 12:17:59 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 2/9] Don't call QUIT in read_string Date: Wed, 13 Apr 2022 13:17:49 -0600 Message-Id: <20220413191756.1146768-3-tromey@adacore.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220413191756.1146768-1-tromey@adacore.com> References: <20220413191756.1146768-1-tromey@adacore.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2022 19:18:02 -0000 read_string does not need to call QUIT, because target_read_memory already does. This change is needed to make string-reading usable by gdbserver. --- gdb/valprint.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/gdb/valprint.c b/gdb/valprint.c index 9990d432e35..65b85cfb038 100644 --- a/gdb/valprint.c +++ b/gdb/valprint.c @@ -2096,7 +2096,6 @@ read_string (CORE_ADDR addr, int len, int width, unsigned int fetchlimit, do { - QUIT; nfetch = std::min ((unsigned long) chunksize, fetchlimit - bufsize); if (*buffer == NULL) @@ -2152,8 +2151,6 @@ read_string (CORE_ADDR addr, int len, int width, unsigned int fetchlimit, consider part of the string (including a '\0' which ends the string). */ *bytes_read = bufptr - buffer->get (); - QUIT; - return errcode; } -- 2.34.1