public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Nils-Christian Kempke <nils-christian.kempke@intel.com>
To: gdb-patches@sourceware.org
Cc: jinisusan.george@amd.com, kevinb@redhat.com,
	Nils-Christian Kempke <nils-christian.kempke@intel.com>
Subject: [PATCH v2 0/1] Fortran entry and DW_TAG_entry_point
Date: Thu, 14 Apr 2022 11:41:07 +0200	[thread overview]
Message-ID: <20220414094108.2758482-1-nils-christian.kempke@intel.com> (raw)

Hi,

please find attached v2 of this series.  It introduced the handling
of DW_TAG_entry_point to GDB.

I want to emphasize again - between gfortran, ifort, and ifx only
ifort seems to currently emit this tag.  So the attached test only
really works when using ifort.  After a comment from Kevin I now added
a gdb.dwarf2 test for GDB's handling of this tag such that it can be
tested without the availablity of a compiler emitting it.

V1 can be found here, it was originally submitted as [RFC]:

https://sourceware.org/pipermail/gdb-patches/2022-March/186900.html

Changes since v1:

	* I rebased to master and removed the partial symbol stuff from
	this patch since this part has been reworked recently.  I hope I
	adapted to the changes correctly.
	* I added the handling of a DW_TAG_entry_points prefix in
	'determine_prefix' (after Jini pointing out a bug here).
	* I removed an if that checked for fortran as the cu's language
	in new_symbol and made the handling of DW_TAG_entry_point
	language agnostic.
	* I changed the return type of 'dwarf2_get_pc_bounds_entry_point'
	to also return PC_BOUNDS_RANGES if the parent die returns these.
	* I added a gdb.dwarf2 test to be able to check this test even
	when one does not have ifort at hand.  The new test compiles
	some .c helper with some labels and uses that to put some
	entry point dwarf on top.  It then checks whether we can break
	at the entry points.

Cheers!
Nils


Nils-Christian Kempke (1):
  dwarf, fortran: add support for DW_TAG_entry_point

 gdb/dwarf2/abbrev.c                           |   1 +
 gdb/dwarf2/read.c                             |  72 ++++++++-
 gdb/testsuite/gdb.dwarf2/dw2-entry-points.c   |  39 +++++
 gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp | 149 ++++++++++++++++++
 gdb/testsuite/gdb.fortran/entry-point.exp     |  84 ++++++++++
 gdb/testsuite/gdb.fortran/entry-point.f90     |  67 ++++++++
 6 files changed, 411 insertions(+), 1 deletion(-)
 create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.c
 create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp
 create mode 100644 gdb/testsuite/gdb.fortran/entry-point.exp
 create mode 100644 gdb/testsuite/gdb.fortran/entry-point.f90

-- 
2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


             reply	other threads:[~2022-04-14  9:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14  9:41 Nils-Christian Kempke [this message]
2022-04-14  9:41 ` [PATCH v2 1/1] dwarf, fortran: add support for DW_TAG_entry_point Nils-Christian Kempke
2022-04-14 22:05   ` Kevin Buettner
2022-04-15 15:27   ` Tom Tromey
2022-05-12 10:38     ` Kempke, Nils-Christian
2022-05-26 17:34       ` Tom Tromey
2022-07-06 15:30         ` Kempke, Nils-Christian
2022-04-19 11:53 ` [PATCH v2 0/1] Fortran entry and DW_TAG_entry_point George, Jini Susan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220414094108.2758482-1-nils-christian.kempke@intel.com \
    --to=nils-christian.kempke@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jinisusan.george@amd.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).