From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by sourceware.org (Postfix) with ESMTPS id F228D3858C83 for ; Thu, 14 Apr 2022 09:41:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F228D3858C83 X-IronPort-AV: E=McAfee;i="6400,9594,10316"; a="243479631" X-IronPort-AV: E=Sophos;i="5.90,259,1643702400"; d="scan'208";a="243479631" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2022 02:41:25 -0700 X-IronPort-AV: E=Sophos;i="5.90,259,1643702400"; d="scan'208";a="573698686" Received: from labpcdell3650-003.iul.intel.com (HELO localhost) ([172.28.49.87]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2022 02:41:23 -0700 From: Nils-Christian Kempke To: gdb-patches@sourceware.org Cc: jinisusan.george@amd.com, kevinb@redhat.com, Nils-Christian Kempke Subject: [PATCH v2 0/1] Fortran entry and DW_TAG_entry_point Date: Thu, 14 Apr 2022 11:41:07 +0200 Message-Id: <20220414094108.2758482-1-nils-christian.kempke@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2022 09:41:29 -0000 Hi, please find attached v2 of this series. It introduced the handling of DW_TAG_entry_point to GDB. I want to emphasize again - between gfortran, ifort, and ifx only ifort seems to currently emit this tag. So the attached test only really works when using ifort. After a comment from Kevin I now added a gdb.dwarf2 test for GDB's handling of this tag such that it can be tested without the availablity of a compiler emitting it. V1 can be found here, it was originally submitted as [RFC]: https://sourceware.org/pipermail/gdb-patches/2022-March/186900.html Changes since v1: * I rebased to master and removed the partial symbol stuff from this patch since this part has been reworked recently. I hope I adapted to the changes correctly. * I added the handling of a DW_TAG_entry_points prefix in 'determine_prefix' (after Jini pointing out a bug here). * I removed an if that checked for fortran as the cu's language in new_symbol and made the handling of DW_TAG_entry_point language agnostic. * I changed the return type of 'dwarf2_get_pc_bounds_entry_point' to also return PC_BOUNDS_RANGES if the parent die returns these. * I added a gdb.dwarf2 test to be able to check this test even when one does not have ifort at hand. The new test compiles some .c helper with some labels and uses that to put some entry point dwarf on top. It then checks whether we can break at the entry points. Cheers! Nils Nils-Christian Kempke (1): dwarf, fortran: add support for DW_TAG_entry_point gdb/dwarf2/abbrev.c | 1 + gdb/dwarf2/read.c | 72 ++++++++- gdb/testsuite/gdb.dwarf2/dw2-entry-points.c | 39 +++++ gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp | 149 ++++++++++++++++++ gdb/testsuite/gdb.fortran/entry-point.exp | 84 ++++++++++ gdb/testsuite/gdb.fortran/entry-point.f90 | 67 ++++++++ 6 files changed, 411 insertions(+), 1 deletion(-) create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.c create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp create mode 100644 gdb/testsuite/gdb.fortran/entry-point.exp create mode 100644 gdb/testsuite/gdb.fortran/entry-point.f90 -- 2.25.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928