From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 3/6] Remove symbol::aclass_index
Date: Wed, 20 Apr 2022 08:50:10 -0600 [thread overview]
Message-ID: <20220420145013.3307418-4-tom@tromey.com> (raw)
In-Reply-To: <20220420145013.3307418-1-tom@tromey.com>
Symbols have an aclass_index method, but this isn't needed, because
the aclass index isn't useful outside of the symbol implementation.
---
gdb/symtab.h | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/gdb/symtab.h b/gdb/symtab.h
index 9b677ffe451..3f9052d76f3 100644
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -1221,11 +1221,6 @@ struct symbol : public general_symbol_info, public allocate_on_obstack
symbol (const symbol &) = default;
symbol &operator= (const symbol &) = default;
- unsigned int aclass_index () const
- {
- return m_aclass_index;
- }
-
void set_aclass_index (unsigned int aclass_index)
{
m_aclass_index = aclass_index;
@@ -1233,7 +1228,7 @@ struct symbol : public general_symbol_info, public allocate_on_obstack
const symbol_impl &impl () const
{
- return symbol_impls[this->aclass_index ()];
+ return symbol_impls[this->m_aclass_index];
}
address_class aclass () const
--
2.34.1
next prev parent reply other threads:[~2022-04-20 14:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 14:50 [PATCH 0/6] More symbol methods Tom Tromey
2022-04-20 14:50 ` [PATCH 1/6] Add accessors for symbol's artificial field Tom Tromey
2022-04-20 15:15 ` Simon Marchi
2022-04-20 15:20 ` Tom Tromey
2022-04-20 14:50 ` [PATCH 2/6] Use array_view for symbol_impls Tom Tromey
2022-04-20 14:50 ` Tom Tromey [this message]
2022-04-20 14:50 ` [PATCH 4/6] Replace symbol_objfile with symbol::objfile Tom Tromey
2022-04-20 14:50 ` [PATCH 5/6] Replace symbol_arch with symbol::arch Tom Tromey
2022-04-20 14:50 ` [PATCH 6/6] Replace symbol_symtab with symbol::symtab Tom Tromey
2022-04-20 15:20 ` Simon Marchi
2022-04-20 15:29 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420145013.3307418-4-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).