From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lsix@lancelotsix.com>
Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111])
 by sourceware.org (Postfix) with ESMTPS id 8264D3838019
 for <gdb-patches@sourceware.org>; Thu, 21 Apr 2022 17:33:10 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8264D3838019
Received: from ubuntu.lan (unknown [IPv6:2a02:390:9086::635])
 by lndn.lancelotsix.com (Postfix) with ESMTPSA id 93B1881D8F;
 Thu, 21 Apr 2022 17:33:09 +0000 (UTC)
Date: Thu, 21 Apr 2022 17:33:00 +0000
From: Lancelot SIX <lsix@lancelotsix.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 04/14] gdb: remove BLOCK_MULTIDICT macro
Message-ID: <20220421173248.3asmhnqh6t26djyt@ubuntu.lan>
References: <20220421145910.15335-1-simon.marchi@efficios.com>
 <20220421145910.15335-4-simon.marchi@efficios.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220421145910.15335-4-simon.marchi@efficios.com>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11
 (lndn.lancelotsix.com [0.0.0.0]); Thu, 21 Apr 2022 17:33:09 +0000 (UTC)
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Apr 2022 17:33:11 -0000

> @@ -1158,8 +1159,8 @@ buildsym_compunit::augment_type_symtab ()
>  	 to the primary symtab.  */
>        set_missing_symtab (m_global_symbols, cust);
>  
> -      mdict_add_pending (BLOCK_MULTIDICT (block),
> -			m_global_symbols);
> +      mdict_add_pending (block->multidict (),
> +                         m_global_symbols);

Hi, I just skimmed through and noticed that here tabs are replaced with
spaces.  (yes, my mail reader highlights this)

Best,
Lancelot.

>      }
>  }