From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id 9CD6E3857C6F for ; Fri, 22 Apr 2022 13:56:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9CD6E3857C6F Received: by mail-io1-xd2e.google.com with SMTP id r12so8654377iod.6 for ; Fri, 22 Apr 2022 06:56:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UUPv4N7fBm8xWzryePRG78D0Bl/hzdJWsW7b8ffrACE=; b=oexE1KZ0i0S9iM780mxufqm/44+l36Wz9B7jevswvjfrYzD2v5/Zg11sc+pCWsLMFH sO0qH+sgY2tgLq1vsPNUwdbeHtCrlT7ZHshtDz1Z7rY3s6u4heAAl0ArZcV016/6+reM QjhjJH9piJRAGu4P5GJkSgCpOYA20d2EAltF9Gj6C/3izySKoTuDJYyKjBAD54dH64Up DEVvz+4EY98ad3HxC+7ot0kKRw0h4XXtxNaLJk96pOtujf3w4OpJXqmVTi5BW4Fzjxdt 51l9ee7wOUdVhlVww9FMTCYBgIX6NOIdB71KcooKxeIY+AK2AXrkOBeWOV8pmpCLFYDH +QaA== X-Gm-Message-State: AOAM5324cn42HPh+LqSIw6N6zUnSxz6LZym3YXxRQxH+yypJJdqeI2cN /IEyShg4GNKDrgO58ZbfUjh7vDD78f70Xg== X-Google-Smtp-Source: ABdhPJz5/0DA3Lp38bSzNU3RAP2UgXKdmjiSEJ8Zr8E6NS9ljgv5izFZkvUdII7o3ckAOVDy34alUg== X-Received: by 2002:a05:6638:d81:b0:32a:b3f9:56b0 with SMTP id l1-20020a0566380d8100b0032ab3f956b0mr1471865jaj.178.1650635798006; Fri, 22 Apr 2022 06:56:38 -0700 (PDT) Received: from murgatroyd.Home (71-211-158-194.hlrn.qwest.net. [71.211.158.194]) by smtp.gmail.com with ESMTPSA id f4-20020a056e0204c400b002caa9f3cc3fsm1365863ils.56.2022.04.22.06.56.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 06:56:37 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 3/4] Use std::string in coff-pe-read.c Date: Fri, 22 Apr 2022 07:56:31 -0600 Message-Id: <20220422135632.2615890-4-tromey@adacore.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220422135632.2615890-1-tromey@adacore.com> References: <20220422135632.2615890-1-tromey@adacore.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2022 13:56:39 -0000 coff-pe-read.c uses xsnprintf and alloca, but using std::string is better, and just as easy. In general I think alloca is something to be avoided, and unbounded uses especially so. --- gdb/coff-pe-read.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c index ae4ca5435b6..5bf0e2dc7f0 100644 --- a/gdb/coff-pe-read.c +++ b/gdb/coff-pe-read.c @@ -178,16 +178,13 @@ add_pe_forwarded_sym (minimal_symbol_reader &reader, struct bound_minimal_symbol msymbol; enum minimal_symbol_type msymtype; int forward_dll_name_len = strlen (forward_dll_name); - int forward_func_name_len = strlen (forward_func_name); - int forward_len = forward_dll_name_len + forward_func_name_len + 2; - char *forward_qualified_name = (char *) alloca (forward_len); short section; - xsnprintf (forward_qualified_name, forward_len, "%s!%s", forward_dll_name, - forward_func_name); + std::string forward_qualified_name = string_printf ("%s!%s", + forward_dll_name, + forward_func_name); - - msymbol = lookup_bound_minimal_symbol (forward_qualified_name); + msymbol = lookup_bound_minimal_symbol (forward_qualified_name.c_str ()); if (!msymbol.minsym) { @@ -195,7 +192,7 @@ add_pe_forwarded_sym (minimal_symbol_reader &reader, for (i = 0; i < forward_dll_name_len; i++) forward_qualified_name[i] = tolower (forward_qualified_name[i]); - msymbol = lookup_bound_minimal_symbol (forward_qualified_name); + msymbol = lookup_bound_minimal_symbol (forward_qualified_name.c_str ()); } if (!msymbol.minsym) -- 2.34.1