From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3C8D2385842B for ; Wed, 27 Apr 2022 12:29:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3C8D2385842B Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-615--yMlaCP1OOuK3eyxb8VA5Q-1; Wed, 27 Apr 2022 08:29:08 -0400 X-MC-Unique: -yMlaCP1OOuK3eyxb8VA5Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 75E24811E75 for ; Wed, 27 Apr 2022 12:29:08 +0000 (UTC) Received: from blarsen.com (ovpn-116-8.gru2.redhat.com [10.97.116.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 504AE2024CAE; Wed, 27 Apr 2022 12:29:01 +0000 (UTC) From: Bruno Larsen To: gdb-patches@sourceware.org Subject: [PATCH v4 0/2] [gdb] untie and validate inheritance location Date: Wed, 27 Apr 2022 09:28:45 -0300 Message-Id: <20220427122847.233260-1-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2022 12:29:11 -0000 Changelog for v4: * rebased on master * removed unnecessary checking after Simon's patch This started with what was thought of as an incorrect inheritance location expression, but turned out to be a correct, but unusual expression, and uncovered an incorrect assumption when calculating offsets of baseclasses. This patchset is the new iteration of that solution, that changed gnuv3_baseclass_offset calculation to allow for non-virtual inheritance that has a non-trivial location expression and also moved the basic validation to this function. The check in value_contents_copy_raw was changed to an assert. Finally, the test was expanded to have one incorrect trivial location, and two non-trivial location expressions, one correct and one incorrect. Bruno Larsen (2): [gdb] Untied inheritance virtuality and loc kind [gdb] Add Simple offset validation when calculating baseclass_offset gdb/gnu-v3-abi.c | 24 +- .../gdb.dwarf2/dw2-inheritance-locexpr-1.exp | 233 +++++++++++++++++ .../gdb.dwarf2/dw2-inheritance-locexpr-2.exp | 235 ++++++++++++++++++ .../gdb.dwarf2/dw2-inheritance-locexpr.c | 69 +++++ gdb/value.c | 8 +- 5 files changed, 562 insertions(+), 7 deletions(-) create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-inheritance-locexpr-1.exp create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-inheritance-locexpr-2.exp create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-inheritance-locexpr.c -- 2.31.1