From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH] Rename Windows debug settings
Date: Wed, 27 Apr 2022 12:32:40 -0600 [thread overview]
Message-ID: <20220427183240.868142-1-tromey@adacore.com> (raw)
The Windows-specific debug settings, like "debugevents", have long
bothered me because they don't follow current GDB conventions. It
seems better to put these commands underneat the existing "set debug"
namespace.
Because these are for debug logging only, I don't think a
compatibility alias is necessary.
---
gdb/NEWS | 12 ++++++++++++
gdb/doc/gdb.texinfo | 16 ++++++++--------
gdb/windows-nat.c | 16 ++++++++--------
3 files changed, 28 insertions(+), 16 deletions(-)
diff --git a/gdb/NEWS b/gdb/NEWS
index 982f4a1a18c..b9e330bb260 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -30,6 +30,18 @@ maintenance info line-table
entry corresponds to an address where a breakpoint should be placed
to be at the first instruction past a function's prologue.
+set debug exec
+show debug exec
+set debug events
+show debug events
+set debug memory
+show debug memory
+set debug exceptions
+show debug exceptions
+ These Windows-specific commands have been renamed to be more
+ consistent with GDB conventions. The old names did not have a
+ space, e.g., "debugeexec".
+
* Python API
** New function gdb.format_address(ADDRESS, PROGSPACE, ARCHITECTURE),
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 38ad2ac32b0..c58e1e79a50 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -24605,26 +24605,26 @@ This affects the way the Windows OS handles
@item show new-group
Displays current value of new-group boolean.
-@kindex set debugevents
-@item set debugevents
+@kindex set debug events
+@item set debug events
This boolean value adds debug output concerning kernel events related
to the debuggee seen by the debugger. This includes events that
signal thread and process creation and exit, DLL loading and
unloading, console interrupts, and debugging messages produced by the
Windows @code{OutputDebugString} API call.
-@kindex set debugexec
-@item set debugexec
+@kindex set debug exec
+@item set debug exec
This boolean value adds debug output concerning execute events
(such as resume thread) seen by the debugger.
-@kindex set debugexceptions
-@item set debugexceptions
+@kindex set debug exceptions
+@item set debug exceptions
This boolean value adds debug output concerning exceptions in the
debuggee seen by the debugger.
-@kindex set debugmemory
-@item set debugmemory
+@kindex set debug memory
+@item set debug memory
This boolean value adds debug output concerning debuggee memory reads
and writes by the debugger.
diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index 1068558cd21..b4342b359ab 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -3062,34 +3062,34 @@ Show creation of new group when creating child process."), NULL,
NULL, /* FIXME: i18n: */
&setlist, &showlist);
- add_setshow_boolean_cmd ("debugexec", class_support, &debug_exec, _("\
+ add_setshow_boolean_cmd ("exec", class_support, &debug_exec, _("\
Set whether to display execution in child process."), _("\
Show whether to display execution in child process."), NULL,
NULL,
NULL, /* FIXME: i18n: */
- &setlist, &showlist);
+ &setdebuglist, &showdebuglist);
- add_setshow_boolean_cmd ("debugevents", class_support, &debug_events, _("\
+ add_setshow_boolean_cmd ("events", class_support, &debug_events, _("\
Set whether to display kernel events in child process."), _("\
Show whether to display kernel events in child process."), NULL,
NULL,
NULL, /* FIXME: i18n: */
- &setlist, &showlist);
+ &setdebuglist, &showdebuglist);
- add_setshow_boolean_cmd ("debugmemory", class_support, &debug_memory, _("\
+ add_setshow_boolean_cmd ("memory", class_support, &debug_memory, _("\
Set whether to display memory accesses in child process."), _("\
Show whether to display memory accesses in child process."), NULL,
NULL,
NULL, /* FIXME: i18n: */
- &setlist, &showlist);
+ &setdebuglist, &showdebuglist);
- add_setshow_boolean_cmd ("debugexceptions", class_support,
+ add_setshow_boolean_cmd ("exceptions", class_support,
&debug_exceptions, _("\
Set whether to display kernel exceptions in child process."), _("\
Show whether to display kernel exceptions in child process."), NULL,
NULL,
NULL, /* FIXME: i18n: */
- &setlist, &showlist);
+ &setdebuglist, &showdebuglist);
init_w32_command_list ();
--
2.34.1
next reply other threads:[~2022-04-27 18:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 18:32 Tom Tromey [this message]
2022-04-27 18:45 ` Eli Zaretskii
2022-04-27 18:50 ` Pedro Alves
2022-04-27 19:04 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427183240.868142-1-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).