From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by sourceware.org (Postfix) with ESMTPS id 7D811383F425 for ; Wed, 11 May 2022 08:07:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D811383F425 X-IronPort-AV: E=McAfee;i="6400,9594,10343"; a="267214201" X-IronPort-AV: E=Sophos;i="5.91,216,1647327600"; d="scan'208";a="267214201" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 01:07:30 -0700 X-IronPort-AV: E=Sophos;i="5.91,216,1647327600"; d="scan'208";a="814363196" Received: from mulvlfelix.iul.intel.com (HELO localhost) ([172.28.48.92]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 01:07:29 -0700 From: Felix Willgerodt To: markus.t.metzger@intel.com, gdb-patches@sourceware.org Subject: [PATCH] gdb, btrace: Throw an error for empty recordings when replaying starts. Date: Wed, 11 May 2022 10:07:07 +0200 Message-Id: <20220511080707.726213-1-felix.willgerodt@intel.com> X-Mailer: git-send-email 2.34.3 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2022 08:07:34 -0000 This makes record_btrace_start_replaying() more consistent, as it already errors out e.g. on a recording with only gaps. --- gdb/record-btrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index 373d82b8b99..3f8a69dd04f 100644 --- a/gdb/record-btrace.c +++ b/gdb/record-btrace.c @@ -2017,7 +2017,7 @@ record_btrace_start_replaying (struct thread_info *tp) /* We can't start replaying without trace. */ if (btinfo->functions.empty ()) - return NULL; + error (_("No trace.")); /* GDB stores the current frame_id when stepping in order to detects steps into subroutines. -- 2.34.3 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928