From: Keith Seitz <keiths@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] linux_nat_target::xfer_partial: Fallback to ptrace
Date: Thu, 12 May 2022 11:15:57 -0700 [thread overview]
Message-ID: <20220512181557.2093666-1-keiths@redhat.com> (raw)
Commit 05c06f318fd9a112529dfc313e6512b399a645e4 enabled GDB
to access memory while threads are running. It did this by accessing
/proc/PID/task/LWP/mem.
Unfortunatley, this interface is not implemented for writing in older kernels
(such as RHEL6). This means that GDB is unable to insert breakpoints on
these hosts:
$ ./gdb -q gdb -ex start
Reading symbols from gdb...
Temporary breakpoint 1 at 0x40fdd5: file ../../src/gdb/gdb.c, line 28.
Starting program: /home/rhel6/fsf/linux/gdb/gdb
Warning:
Cannot insert breakpoint 1.
Cannot access memory at address 0x40fdd5
(gdb)
Before this patch, linux_proc_xfer_memory_partial (previously called
linux_proc_xfer_partial) would return TARGET_XFER_EOF if the write
to /proc/PID/mem failed. [More specifically, linux_proc_xfer_partial would
not "bother for one word," but the effect is the essentially same.]
This status was checked by linux_nat_target::xfer_partial, which would then
fallback to using ptrace to perform the operation.
This is the specific hunk that removed the fallback:
- xfer = linux_proc_xfer_partial (object, annex, readbuf, writebuf,
- offset, len, xfered_len);
- if (xfer != TARGET_XFER_EOF)
- return xfer;
+ return linux_proc_xfer_memory_partial (readbuf, writebuf,
+ offset, len, xfered_len);
+ }
return inf_ptrace_target::xfer_partial (object, annex, readbuf, writebuf,
offset, len, xfered_len);
This patch restores this fallback mechanism, enabling GDB to insert
breakpoints on these older kernels.
Tested on {unix,native-gdbserver,native-extended-gdbserver}/-m{32,64}
on x86_64, s390x, aarch64, and ppc64le.
---
gdb/linux-nat.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index 740cc0ddfc0..f5490c27bf5 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -3706,8 +3706,12 @@ linux_nat_target::xfer_partial (enum target_object object,
if (addr_bit < (sizeof (ULONGEST) * HOST_CHAR_BIT))
offset &= ((ULONGEST) 1 << addr_bit) - 1;
- return linux_proc_xfer_memory_partial (readbuf, writebuf,
- offset, len, xfered_len);
+ enum target_xfer_status xfer
+ = linux_proc_xfer_memory_partial (readbuf, writebuf,
+ offset, len, xfered_len);
+ if (xfer != TARGET_XFER_EOF)
+ return xfer;
+ /* Fallthrough to ptrace. */
}
return inf_ptrace_target::xfer_partial (object, annex, readbuf, writebuf,
--
2.36.1
next reply other threads:[~2022-05-12 18:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 18:15 Keith Seitz [this message]
2022-05-20 18:51 ` Pedro Alves
2022-05-24 18:56 ` Keith Seitz
2022-05-25 13:41 ` Pedro Alves
2022-06-03 15:18 Keith Seitz
2022-07-21 15:03 ` Keith Seitz
2022-07-21 20:07 ` Pedro Alves
2022-07-26 17:24 ` Keith Seitz
2022-07-26 19:16 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512181557.2093666-1-keiths@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).