[PATCH 00/23] More breakpoints cleanups

[Pedro Alves <pedro@palves.net>]

The main goal of this series was to eliminate init_raw_breakpoint.

It slowly tweaks a number of things to be able to do that.

Along the way, it converts the remaining init_foo functions to proper
ctors, and tweaks the class hierarchy a bit such that all code
breakpoints inherit from base_breakpoint.  In the end, it proposes
renaming base_breakpoint to code_breakpoint.

By inspection, I ran into a couple bugs around momentary breakpoints.
There are a couples patches in here to fix them.

I also noticed that nothing currently exercises the paths that make
create_breakpoints_sal actually create more than one breakpoint.  One
of the patches here is about adding a testcase for that.

See the individual patches for details.

Pedro Alves (23):
  add_location_to_breakpoint -> breakpoint::add_location
  Make structs breakpoint/base_breakpoint/catchpoint be abstract
  ranged_breakpoint: don't use init_raw_breakpoint
  ranged_breakpoint, use install_breakpoint
  ranged_breakpoint - move initialization to ctor
  Make a few functions work with base_breakpoint instead of breakpoint
  More breakpoint_ops parameter elimination
  Remove "internal" parameter from a couple functions
  init_breakpoint_sal -> base_breakpoint::base_breakpoint
  Make ada_catchpoint_location's owner ctor parameter be ada_catchpoint
  Convert init_ada_exception_catchpoint to a ctor
  Refactor set_internal_breakpoint / internal_breakpoint ctor
  Refactor momentary breakpoints, eliminate
    set_raw_breakpoint{,_without_location}
  Make exception_catchpoint inherit base_breakpoint instead of
    catchpoint
  Make breakpoint_address_bits look at the location kind
  Make catchpoint inherit breakpoint, eliminate init_raw_breakpoint
  Move common bits of catchpoint/exception_catchpoint to breakpoint's
    ctor
  Move add_location(sal) to base_breakpoint
  Add/tweak intro comments of struct breakpoint and several subclasses
  Momentary breakpoints should have no breakpoint number
  Make sure momentary breakpoints are always thread-specific
  Test "set multiple-symbols on" creating multiple breakpoints
  Rename base_breakpoint -> code_breakpoint

 gdb/ada-lang.c                     |  81 ++-
 gdb/break-catch-syscall.c          |   6 +-
 gdb/break-catch-throw.c            |  14 +-
 gdb/breakpoint.c                   | 805 ++++++++++++-----------------
 gdb/breakpoint.h                   |  93 ++--
 gdb/elfread.c                      |   6 +-
 gdb/mi/mi-cmd-break.c              |   4 +-
 gdb/minsyms.c                      |   4 +-
 gdb/python/py-finishbreakpoint.c   |   2 +-
 gdb/symtab.h                       |   5 +-
 gdb/testsuite/gdb.cp/ovldbreak.exp | 100 +++-
 11 files changed, 546 insertions(+), 574 deletions(-)


base-commit: e90601a4f1af82ff5350797ddc54e24efd731535
-- 
2.36.0