From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by sourceware.org (Postfix) with ESMTPS id 02AA23856DC3 for ; Mon, 16 May 2022 18:40:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 02AA23856DC3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f49.google.com with SMTP id r30so3983943wra.13 for ; Mon, 16 May 2022 11:40:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=V3caV1t+ZM8KAen1r6il3IDsQeKKibSVhFCyimvJxMI=; b=eMJLVr/CtX/cpW3UjMMFzhtUySwlao3IiVlJw+g1A2/DYIuJlc+Sw5c5/0rtW5bEPp kjd9XK3fTAVdHtxAIeXNHLs9AKxeOKCUBqeDxpio3Oi0o4ouMEJfax4Kw/xH9ZB2O0zA n0iistEjYkKfoCwkrRY6+wGVBKX2L4UQQY8hu2MEhQeoWghnaIqXDNdQ+aTZ9AgmIuQA D09Y9NO1xlfPl3iWsrpqbvtFwXvhGOopYCkVXv+THXrcG+G6NZW4PefNj/9YA8o+caYJ QkIN3bZAFf3U+IZ+wRLlzMJ+Hoh/Yibxy9iFqSKilFCGRkCO3CW6Y+hXtdpBV9AzmBSV A9Ag== X-Gm-Message-State: AOAM53275Y8j1Bsa09IsPZdckWP/p6TKIjGZCz3FdcLLSGu3mTtYRrpN Z8DntoAjG4PEHCuc6QxTl7JC/N9pFAA= X-Google-Smtp-Source: ABdhPJzOwPKRPvFhTEJX0C9FAhReX5ca9fJbkuhudE/wc1N2xvG7K8sxQwICjqrLLZtVmYCAfYMLgg== X-Received: by 2002:a5d:59ae:0:b0:20c:6f97:31b5 with SMTP id p14-20020a5d59ae000000b0020c6f9731b5mr15019660wrr.279.1652726441260; Mon, 16 May 2022 11:40:41 -0700 (PDT) Received: from localhost ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id e3-20020a05600c4e4300b003942a244ed2sm45109wmq.23.2022.05.16.11.40.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 May 2022 11:40:40 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 04/23] ranged_breakpoint, use install_breakpoint Date: Mon, 16 May 2022 19:40:11 +0100 Message-Id: <20220516184030.665489-5-pedro@palves.net> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220516184030.665489-1-pedro@palves.net> References: <20220516184030.665489-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2022 18:40:44 -0000 This commit replaces a chunk of code in break_range_command by an equivalent call to install_breakpoint. Change-Id: I31c06cabd36f5be91740aab029265f678aa78e35 --- gdb/breakpoint.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index f9332e1f998..ced976ca39d 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -9356,7 +9356,6 @@ break_range_command (const char *arg, int from_tty) struct linespec_result canonical_start, canonical_end; int bp_count, can_use_bp, length; CORE_ADDR end; - struct breakpoint *b; /* We don't support software ranged breakpoints. */ if (target_ranged_break_num_registers () < 0) @@ -9440,18 +9439,12 @@ break_range_command (const char *arg, int from_tty) /* Now set up the breakpoint. */ std::unique_ptr br (new ranged_breakpoint (get_current_arch ())); br->add_location (sal_start); - b = add_to_breakpoint_chain (std::move (br)); - - set_breakpoint_count (breakpoint_count + 1); - b->number = breakpoint_count; - b->disposition = disp_donttouch; - b->location = std::move (start_location); - b->location_range_end = std::move (end_location); - b->loc->length = length; + br->disposition = disp_donttouch; + br->location = std::move (start_location); + br->location_range_end = std::move (end_location); + br->loc->length = length; - mention (b); - gdb::observers::breakpoint_created.notify (b); - update_global_location_list (UGLL_MAY_INSERT); + install_breakpoint (false, std::move (br), true); } /* Return non-zero if EXP is verified as constant. Returned zero -- 2.36.0