From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by sourceware.org (Postfix) with ESMTPS id C2019385626F for ; Wed, 18 May 2022 18:00:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C2019385626F Received: by mail-io1-xd33.google.com with SMTP id s23so3108904iog.13 for ; Wed, 18 May 2022 11:00:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FjELFzKd44NSGO1GtLKaV3ikBK2SVuajCGyqP9Tjfm8=; b=n4onm8Y9gQtRQqFSQbWXkXbVEApsf/7uKqv0HmF92N/Ph1ta6k70dQkvQOV1olEB90 KkENmy9o2xZGhUY5VcYujPX8u0HaO6Y/EKHF0bkUjHqc/hqqMAaGne+C3qolGfFYElPa mxyYSjL/8TIFQorTg3wV8m32AKNRiq9TAFb92UhFs9+cg1iaL6Lczcl1le0NToO0SYOv +ZGvRt8RBRvjzBMbNPScVbCHEkypFIPslnNfbvWSylczbMLG4wv2U8PkFgegDQa/UtuI EQ7iJnQgJib09Ey1n5MVYV3H/hRzRNJSuYSsY/i8X5IdoPGfeSKJZHUkEEaCrrJNmCxa HXYg== X-Gm-Message-State: AOAM531i2Rb0oHWw/wjwftv1s44aH6ta6pluPOXoCQUBLa6wit+VDMen r7S9Fjj5kphsRhVkDFC+U8RhZqIYkK+vHw== X-Google-Smtp-Source: ABdhPJyltEvdyqpWLrOk9aXmVCT7zsZpmnvBWVij11rJaJwxjKIflPy7OABdEt5MJ3q9XDnXNeB5Xg== X-Received: by 2002:a5d:9d91:0:b0:65a:a660:3904 with SMTP id ay17-20020a5d9d91000000b0065aa6603904mr419579iob.42.1652896854087; Wed, 18 May 2022 11:00:54 -0700 (PDT) Received: from murgatroyd.Home (71-211-158-194.hlrn.qwest.net. [71.211.158.194]) by smtp.gmail.com with ESMTPSA id r4-20020a92d984000000b002cde6e352ffsm715083iln.73.2022.05.18.11.00.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 11:00:53 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 01/14] Fix ODR warning in observable.h Date: Wed, 18 May 2022 12:00:36 -0600 Message-Id: <20220518180049.2337257-2-tromey@adacore.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220518180049.2337257-1-tromey@adacore.com> References: <20220518180049.2337257-1-tromey@adacore.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2022 18:00:56 -0000 observable.h triggers an ODR warning because this line: extern observable target_changed; ... may be the only declaration of "struct target_ops" in scope (depending on the particular .c file) -- and this declares it in a namespace, resulting in confusion. This patch fixes the problem by adding a forward declaration. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=22395 --- gdb/observable.h | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/observable.h b/gdb/observable.h index f426c1a761f..796bf2a43c6 100644 --- a/gdb/observable.h +++ b/gdb/observable.h @@ -28,6 +28,7 @@ struct objfile; struct thread_info; struct inferior; struct process_stratum_target; +struct target_ops; struct trace_state_variable; namespace gdb -- 2.34.1