From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by sourceware.org (Postfix) with ESMTPS id BA826385E012 for ; Wed, 18 May 2022 18:00:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BA826385E012 Received: by mail-io1-xd36.google.com with SMTP id e15so3160949iob.3 for ; Wed, 18 May 2022 11:00:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QpRjpKnG5EE73DJHl/n7pNvZpoiLLp30B9ZWafuI3HE=; b=QBkbt1mrFU+zgQ4wBos5SN82Fv/2LdBqyzHWcVpBcl23pWTqJ01sLoYqfCNizPqHyQ eGYMHNzvcJDIhWAB/8FP9Nwkrr/Q9moHBzCpbM72J8ZuNuNtd/F4KE9OvHMLxoR07tOe Lr/BVN0rUPCbl91zb4z54BK9lv/8p2McRdMIhgKtUsZDNGHfvDjIqPjez05R+i0DuRRA M+qo1zdqIzozu7xUUMyS35lTODD8fa9sDcV7ApMu+y0olPTqdJERs4v1D7J0QCXl9UMH BecAO6GKAavU9q2G9hjBtZD/tgH9hD69tPfNaujcr4s2FOmAqNH3ADouwVVRGXmhxn/B rhnw== X-Gm-Message-State: AOAM533Z0EYhtpQKgJJHzoO6PRvOGBfM0OHkHIxw13bzvJuN7LI+Y3SR 40A4WWyJw+4w0vvPVp9lsBedW5iJUBY7HQ== X-Google-Smtp-Source: ABdhPJwghTA+sMCeerTbZGxzRotSaV01L3EL+n9frzJYzZ9Az7zXOoLVN8vzSy503v+dPFEVMqDjUw== X-Received: by 2002:a05:6638:498b:b0:32b:e416:e830 with SMTP id cv11-20020a056638498b00b0032be416e830mr421861jab.152.1652896855114; Wed, 18 May 2022 11:00:55 -0700 (PDT) Received: from murgatroyd.Home (71-211-158-194.hlrn.qwest.net. [71.211.158.194]) by smtp.gmail.com with ESMTPSA id r4-20020a92d984000000b002cde6e352ffsm715083iln.73.2022.05.18.11.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 11:00:54 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 02/14] ODR warnings for struct symloc Date: Wed, 18 May 2022 12:00:37 -0600 Message-Id: <20220518180049.2337257-3-tromey@adacore.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220518180049.2337257-1-tromey@adacore.com> References: <20220518180049.2337257-1-tromey@adacore.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2022 18:00:57 -0000 "struct symloc" is defined in multiple spots in gdb, causing ODR warnings. This patch renames these. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=22395 --- gdb/mdebugread.c | 10 +++++----- gdb/xcoffread.c | 28 ++++++++++++++-------------- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/gdb/mdebugread.c b/gdb/mdebugread.c index ca7c15ee63f..a2280c3ba8d 100644 --- a/gdb/mdebugread.c +++ b/gdb/mdebugread.c @@ -86,7 +86,7 @@ static struct objfile *mdebugread_objfile; /* We put a pointer to this structure in the read_symtab_private field of the psymtab. */ -struct symloc +struct md_symloc { /* Index of the FDR that this psymtab represents. */ int fdr_idx; @@ -102,7 +102,7 @@ struct symloc enum language pst_language; }; -#define PST_PRIVATE(p) ((struct symloc *)(p)->read_symtab_private) +#define PST_PRIVATE(p) ((struct md_symloc *)(p)->read_symtab_private) #define FDR_IDX(p) (PST_PRIVATE(p)->fdr_idx) #define CUR_BFD(p) (PST_PRIVATE(p)->cur_bfd) #define DEBUG_SWAP(p) (PST_PRIVATE(p)->debug_swap) @@ -2604,8 +2604,8 @@ parse_partial_symbols (minimal_symbol_reader &reader, textlow = 0; pst = new legacy_psymtab (fdr_name (fh), partial_symtabs, objfile->per_bfd, textlow); - pst->read_symtab_private = XOBNEW (&objfile->objfile_obstack, symloc); - memset (pst->read_symtab_private, 0, sizeof (struct symloc)); + pst->read_symtab_private = XOBNEW (&objfile->objfile_obstack, md_symloc); + memset (pst->read_symtab_private, 0, sizeof (struct md_symloc)); save_pst = pst; FDR_IDX (pst) = f_idx; @@ -4649,7 +4649,7 @@ new_psymtab (const char *name, psymtab_storage *partial_symtabs, /* Keep a backpointer to the file's symbols. */ psymtab->read_symtab_private - = OBSTACK_ZALLOC (&objfile->objfile_obstack, symloc); + = OBSTACK_ZALLOC (&objfile->objfile_obstack, md_symloc); CUR_BFD (psymtab) = cur_bfd; DEBUG_SWAP (psymtab) = debug_swap; DEBUG_INFO (psymtab) = debug_info; diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c index d8735d29ede..9adc841b1f1 100644 --- a/gdb/xcoffread.c +++ b/gdb/xcoffread.c @@ -59,7 +59,7 @@ /* We put a pointer to this structure in the read_symtab_private field of the psymtab. */ -struct symloc +struct xcoff_symloc { /* First symbol number for this file. */ @@ -598,7 +598,7 @@ process_linenos (CORE_ADDR start, CORE_ADDR end) unsigned *firstLine; offset = - ((struct symloc *) this_symtab_psymtab->read_symtab_private)->lineno_off; + ((struct xcoff_symloc *) this_symtab_psymtab->read_symtab_private)->lineno_off; if (offset == 0) goto return_after_cleanup; @@ -966,9 +966,9 @@ read_xcoff_symtab (struct objfile *objfile, legacy_psymtab *pst) start_compunit_symtab (objfile, filestring, NULL, file_start_addr, pst_symtab_language); record_debugformat (debugfmt); - symnum = ((struct symloc *) pst->read_symtab_private)->first_symnum; + symnum = ((struct xcoff_symloc *) pst->read_symtab_private)->first_symnum; max_symnum = - symnum + ((struct symloc *) pst->read_symtab_private)->numsyms; + symnum + ((struct xcoff_symloc *) pst->read_symtab_private)->numsyms; first_object_file_end = 0; raw_symbol = xcoff->symtbl + symnum * local_symesz; @@ -1747,7 +1747,7 @@ xcoff_expand_psymtab (legacy_psymtab *pst, struct objfile *objfile) /* Read in all partial symtabs on which this one is dependent. */ pst->expand_dependencies (objfile); - if (((struct symloc *) pst->read_symtab_private)->numsyms != 0) + if (((struct xcoff_symloc *) pst->read_symtab_private)->numsyms != 0) { /* Init stuff necessary for reading in symbols. */ stabsread_init (); @@ -1767,7 +1767,7 @@ xcoff_read_symtab (legacy_psymtab *self, struct objfile *objfile) { gdb_assert (!self->readin); - if (((struct symloc *) self->read_symtab_private)->numsyms != 0 + if (((struct xcoff_symloc *) self->read_symtab_private)->numsyms != 0 || self->number_of_dependencies) { next_symbol_text_func = xcoff_next_symbol_text; @@ -1892,8 +1892,8 @@ xcoff_start_psymtab (psymtab_storage *partial_symtabs, objfile->per_bfd, 0); result->read_symtab_private = - XOBNEW (&objfile->objfile_obstack, struct symloc); - ((struct symloc *) result->read_symtab_private)->first_symnum = first_symnum; + XOBNEW (&objfile->objfile_obstack, struct xcoff_symloc); + ((struct xcoff_symloc *) result->read_symtab_private)->first_symnum = first_symnum; result->legacy_read_symtab = xcoff_read_symtab; result->legacy_expand_psymtab = xcoff_expand_psymtab; @@ -1922,10 +1922,10 @@ xcoff_end_psymtab (struct objfile *objfile, psymtab_storage *partial_symtabs, int i; if (capping_symbol_number != -1) - ((struct symloc *) pst->read_symtab_private)->numsyms = + ((struct xcoff_symloc *) pst->read_symtab_private)->numsyms = capping_symbol_number - - ((struct symloc *) pst->read_symtab_private)->first_symnum; - ((struct symloc *) pst->read_symtab_private)->lineno_off = + - ((struct xcoff_symloc *) pst->read_symtab_private)->first_symnum; + ((struct xcoff_symloc *) pst->read_symtab_private)->lineno_off = first_fun_line_offset; first_fun_line_offset = 0; @@ -1947,9 +1947,9 @@ xcoff_end_psymtab (struct objfile *objfile, psymtab_storage *partial_symtabs, legacy_psymtab *subpst = new legacy_psymtab (include_list[i], partial_symtabs, objfile->per_bfd); - subpst->read_symtab_private = XOBNEW (&objfile->objfile_obstack, symloc); - ((struct symloc *) subpst->read_symtab_private)->first_symnum = 0; - ((struct symloc *) subpst->read_symtab_private)->numsyms = 0; + subpst->read_symtab_private = XOBNEW (&objfile->objfile_obstack, xcoff_symloc); + ((struct xcoff_symloc *) subpst->read_symtab_private)->first_symnum = 0; + ((struct xcoff_symloc *) subpst->read_symtab_private)->numsyms = 0; /* We could save slight bits of space by only making one of these, shared by the entire set of include files. FIXME-someday. */ -- 2.34.1