From: Jon Turney <jon.turney@dronecode.org.uk>
To: gdb-patches@sourceware.org
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH 4/4] Fix a new warning on Cygwin
Date: Sat, 21 May 2022 12:10:57 +0100 [thread overview]
Message-ID: <20220521111057.13089-5-jon.turney@dronecode.org.uk> (raw)
In-Reply-To: <20220521111057.13089-1-jon.turney@dronecode.org.uk>
> ../../gdb/windows-nat.c: In function ‘windows_solib* windows_make_so(const char*, LPVOID)’:
> ../../gdb/windows-nat.c:714:12: error: declaration of ‘char name [512]’ shadows a parameter [-Werror=shadow=compatible-local]
> 714 | char name[SO_NAME_MAX_PATH_SIZE];
> | ^~~~
> ../../gdb/windows-nat.c:655:30: note: shadowed declaration is here
> 655 | windows_make_so (const char *name, LPVOID load_addr)
> | ~~~~~~~~~~~~^~~~
---
gdb/windows-nat.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index b98848bbc70..8631a1b4569 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -711,10 +711,10 @@ windows_make_so (const char *name, LPVOID load_addr)
#else
if (buf[0])
{
- char name[SO_NAME_MAX_PATH_SIZE];
- cygwin_conv_path (CCP_WIN_W_TO_POSIX, buf, name,
+ char cname[SO_NAME_MAX_PATH_SIZE];
+ cygwin_conv_path (CCP_WIN_W_TO_POSIX, buf, cname,
SO_NAME_MAX_PATH_SIZE);
- so->name = name;
+ so->name = cname;
}
else
{
--
2.36.1
next prev parent reply other threads:[~2022-05-21 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-21 11:10 [PATCH 0/4] Various Cygwin build fixes Jon Turney
2022-05-21 11:10 ` [PATCH 1/4] Fix Cygwin build after fcab5839 Jon Turney
2022-05-21 11:10 ` [PATCH 2/4] Fix Cygwin build after 0578e87f Jon Turney
2022-05-21 11:10 ` [PATCH 3/4] Fix Cygwin build after 85b25bd9 Jon Turney
2022-05-21 11:10 ` Jon Turney [this message]
2022-05-26 16:55 ` [PATCH 0/4] Various Cygwin build fixes Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220521111057.13089-5-jon.turney@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).