From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 4A48F383B788 for ; Mon, 23 May 2022 11:05:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4A48F383B788 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6D6B41F8F9 for ; Mon, 23 May 2022 11:05:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5A5D9139F5 for ; Mon, 23 May 2022 11:05:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ENXiFG9qi2JxFQAAMHmgww (envelope-from ) for ; Mon, 23 May 2022 11:05:19 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 8/8] [gdb/ada] Fix literal truncation Date: Mon, 23 May 2022 13:05:18 +0200 Message-Id: <20220523110518.2447-8-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220523110518.2447-1-tdevries@suse.de> References: <20220523110518.2447-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2022 11:05:22 -0000 Make sure we error out on overflow instead of truncating in all cases. Tested on x86_64-linux, with a build with --enable-targets=all. --- gdb/ada-lex.l | 27 +++++++++++++++++++++---- gdb/testsuite/gdb.base/parse_number.exp | 4 +--- 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/gdb/ada-lex.l b/gdb/ada-lex.l index 33a08eaa93b..002eb811e41 100644 --- a/gdb/ada-lex.l +++ b/gdb/ada-lex.l @@ -466,12 +466,16 @@ processInt (struct parser_state *par_state, const char *base0, if (mpz_cmp (result.val, maxval.val) > 0) error (_("Integer literal out of range")); + int int_bits = gdbarch_int_bit (par_state->gdbarch ()); + int long_bits = gdbarch_long_bit (par_state->gdbarch ()); + int long_long_bits = gdbarch_long_long_bit (par_state->gdbarch ()); + ULONGEST value = result.as_integer (); - if ((value >> (gdbarch_int_bit (par_state->gdbarch ())-1)) == 0) + if (fits_in_type (1, value, int_bits, true)) yylval.typed_val.type = type_int (par_state); - else if ((value >> (gdbarch_long_bit (par_state->gdbarch ())-1)) == 0) + else if (fits_in_type (1, value, long_bits, true)) yylval.typed_val.type = type_long (par_state); - else if (((value >> (gdbarch_long_bit (par_state->gdbarch ())-1)) >> 1) == 0) + else if (fits_in_type (1, value, long_bits, false)) { /* We have a number representable as an unsigned integer quantity. For consistency with the C treatment, we will treat it as an @@ -490,8 +494,23 @@ processInt (struct parser_state *par_state, const char *base0, yylval.typed_val.val = (LONGEST) value; return INT; } - else + else if (fits_in_type (1, value, long_long_bits, true)) yylval.typed_val.type = type_long_long (par_state); + else if (fits_in_type (1, value, long_long_bits, false)) + { + /* Note: Interprets ULLONG_MAX as -1. */ + yylval.typed_val.type = type_long_long (par_state); + /* See unsigned long case above. */ + if (value & LONGEST_SIGN) + yylval.typed_val.val = + (LONGEST) (value & ~LONGEST_SIGN) + - (LONGEST_SIGN>>1) - (LONGEST_SIGN>>1); + else + yylval.typed_val.val = (LONGEST) value; + return INT; + } + else + error (_("Integer literal out of range")); yylval.typed_val.val = value; return INT; diff --git a/gdb/testsuite/gdb.base/parse_number.exp b/gdb/testsuite/gdb.base/parse_number.exp index 6e0091278a9..70b0ad065d7 100644 --- a/gdb/testsuite/gdb.base/parse_number.exp +++ b/gdb/testsuite/gdb.base/parse_number.exp @@ -146,9 +146,7 @@ proc parse_number { lang n } { return [list "<$sizeof_long_long-byte integer>" $n] } else { # Overflow. - # Some truncated value or re_overflow, should be re_overflow. - return [list "($re_overflow|<$decimal-byte integer>)" \ - ($re_overflow|$any)] + return [list $re_overflow $re_overflow] } } elseif { $lang == "modula-2" } { if { [string equal $n -0] } { -- 2.35.3