From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2044.outbound.protection.outlook.com [40.107.220.44]) by sourceware.org (Postfix) with ESMTPS id 8CC203838028 for ; Wed, 25 May 2022 09:30:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8CC203838028 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gOGB1otECzTNMmSc0jlsyO5EGiUyYNMjNqj8NMl0j5zH1oQ5zef2B+eDZgkuBkIJo2N77JfT4YQ0qLAR6OtdvDVXuszKxSTAND9fDVzGvVdM4w7IrUC6vvu7SAFbssAdJSJqETWGmrRNtZvUepiqOq/jujQ9nVS7AITJhH3ke8/F4OI6Fu5dTensOk6LOhdE5Ub3/5OZ7Hl1gsFbJOXtI38Todwc6Sb3r/HvErD5QQAaYOAB5VeSesP0oS0C4kYpH983sxPzBt7NBuDIa+XeIBnuJNGb5/OjtLOQGoakC4klW9jVWFj/cZZJ6L+qSlVCa4gblKf8sv7SFTSZ2dorWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=usuFC7vzMlJtleDJLH6JJLIdxoI98GYI5+bQyzSeDpQ=; b=jIfNi4JcG+SGMQU3geNqf+5MAQ0bsJV4dIzAq0tXayOfdqIcmeIJrKKkpwmVB2YiEz2SAiv728ULM1lNeJe4mIlzpiWcLiGB3vqo81y9gzP6QPql5MnVUHnBDPn97QEndNsWReBKJB9MCIOebhR2+mMvgVvfl0RV+rrjKJhX0UnIUHI7ezLPRniP5SreDBldbpHl4X0PtRz98ailulVlJqiMALHDjTXApndcM0OWOaklTSy51WYY12DzHmfWVgDH37DYyjLv07Db8S/ND0vHK/znHYuOfjGXW18L+JjBhNoGjJAf962qi15CCZkp8WERLMINPPe86MAlN7XS2t9/fA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none Received: from MW4PR04CA0239.namprd04.prod.outlook.com (2603:10b6:303:87::34) by BY5PR12MB4242.namprd12.prod.outlook.com (2603:10b6:a03:203::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15; Wed, 25 May 2022 09:30:22 +0000 Received: from CO1NAM11FT009.eop-nam11.prod.protection.outlook.com (2603:10b6:303:87:cafe::33) by MW4PR04CA0239.outlook.office365.com (2603:10b6:303:87::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Wed, 25 May 2022 09:30:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT009.mail.protection.outlook.com (10.13.175.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5293.13 via Frontend Transport; Wed, 25 May 2022 09:30:21 +0000 Received: from khazad-dum.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 25 May 2022 04:30:19 -0500 From: Lancelot SIX To: CC: , Lancelot SIX Subject: [PATCH] gdb/linux-nat: xfer_memory_partial return E_IO on error Date: Wed, 25 May 2022 10:29:57 +0100 Message-ID: <20220525092957.2969989-1-lancelot.six@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8b449745-7199-4b8b-2de1-08da3e3130be X-MS-TrafficTypeDiagnostic: BY5PR12MB4242:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7eYyeC3zucuQQwa3IUzajjuQfzj0XXxXwF9BVqHeCr3lZGkHOtSFtrlpZY7ux3Iap4tjSIomLNqiXryxuIw8C26Bk+Bxa9CxEjYgLHE6qDGiDnepC8oEMc5SPU4C7Hj3xcwnzx0jBqzIV/XB0FczIHaqmaesVKcnrwG0WSycboRRqLWbUoKNp4RBr3+PncniSlpgfNYJZAO+I9Ds5abqouYNdOG9JcyZPPgLPzbhdtWuPR+MXi09Kn8i5vrBwbAOCZbDEXHDnKjzPfMUvA+QSJU6t1mKGSBxQ/LPRQg91VXUPk/m+AKO/sWEMJoGbP9W47m/5BeZo4IoVpOghkylDXhGkGINWxHGhh9/TNjY/xC63ZSqNSOy/Szf6WZoqnwNSOSUr4aaGVBDb4Zmtidb5Z9h8xVgZSgbDqtoowd0Y6JATqCuhH3V4TKK70Yh5hfpF2oGIHhim45dX76gV3IRbkoMiD4IqcETfXODXQCKnBvgX2uasfmf6/QFzTkC+GKggLGKvVQRZYoleCeS0+dDy4VBFnbOLEK7j0FdxDFSu6rt0lHYtEavbcAlxuxnWRlhRHW3FZip6JFl3/hrEjtd6OEyvLmpqISLJ1xBouzPGAAgYybNedIQUiDTXf1vrNYSINKSCf3itIwD4oCM0loKBZ1B0jjK5a5Zg9L+4mv/dnkQaMfSnH4Eddge1BM4LCvsNyLTt6yK/lMLQtPr+iyRqw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(4326008)(26005)(82310400005)(5660300002)(36756003)(54906003)(2906002)(7696005)(70206006)(8676002)(70586007)(8936002)(508600001)(6666004)(316002)(6916009)(36860700001)(336012)(47076005)(426003)(2616005)(16526019)(186003)(1076003)(40460700003)(83380400001)(356005)(81166007)(86362001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2022 09:30:21.6561 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8b449745-7199-4b8b-2de1-08da3e3130be X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT009.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4242 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 09:30:27 -0000 When accessing /proc/PID/mem, if pread64/pwrite64/read/write encounters an error and return -1, linux_proc_xfer_memory_partial return TARGET_XFER_EOF. I think it should return TARGET_XFER_E_IO in this case. TARGET_XFER_EOF is returned when pread64/pwrite64/read/frite returns 0, which indicates that the address space is gone and the whole process has exited or execed. This patch makes this change. Regression tested on x86_64-linux-gnu. Change-Id: I6030412459663b8d7933483fdda22a6c2c5d7221 --- gdb/linux-nat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c index 3b5400896bc..b9164e621db 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -3917,7 +3917,7 @@ linux_proc_xfer_memory_partial (gdb_byte *readbuf, const gdb_byte *writebuf, linux_nat_debug_printf ("accessing fd %d for pid %d failed: %s (%d)", fd, inferior_ptid.pid (), safe_strerror (errno), errno); - return TARGET_XFER_EOF; + return TARGET_XFER_E_IO; } else if (ret == 0) { base-commit: 51498ab9abc6122817428198e831d36923e293a4 -- 2.25.1