From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by sourceware.org (Postfix) with ESMTPS id 8397838560B3 for ; Thu, 26 May 2022 16:20:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8397838560B3 Received: by mail-io1-xd32.google.com with SMTP id d198so2019731iof.12 for ; Thu, 26 May 2022 09:20:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5wrQ650WPj9SOOr+N8RhtYZaKZR55FDCrMngRBgbnh8=; b=hsjebSdTz1hJX7ySjktnAC6eyNywicryD88Hz4KqykQYJTZVrCIv16bsH7l3cGMymZ CB+n8csHyGTGQECsTNFe/WYOU1BamjlCzwBXn83BgL95gr3+PlXct//CN1skTMDUPsU1 m4FPW2ZYDRNxhkQa9GbuT4KnXGKC1BQzYqjEss/njWCdfTq0FwJ+GPMCNGprB9a+5jRO 0cgaQ80LFS0ESQW7bukOkQ/hQTZK5O8DmhGSxkvQXaJagJRXTFhcdVODca/1Mrpb4dfl NGrIkXJRjjhZdGLm//XgP6UEQ0j92EeMQizh63sN8vOwMZPKi3Sc43lJK6P8D3tILTuD Xdog== X-Gm-Message-State: AOAM531WOa7DMHLHdYTgWj30SmtZheEa5Ad9v3C9acNfPScYZT+FBw5u pFUNk6OerrsdhLX7GT8MvzAT3Ydfw2hqiA== X-Google-Smtp-Source: ABdhPJxqLiKekuE2nb2l8K5CojrFJijmJo7g+OlP/cjyWsd1JFEpljhlvInh9C0yefiQRfIMQ6JLaQ== X-Received: by 2002:a05:6638:238b:b0:32e:e939:fee6 with SMTP id q11-20020a056638238b00b0032ee939fee6mr7644755jat.281.1653581999759; Thu, 26 May 2022 09:19:59 -0700 (PDT) Received: from murgatroyd.Home (71-211-158-194.hlrn.qwest.net. [71.211.158.194]) by smtp.gmail.com with ESMTPSA id t15-20020a92dc0f000000b002d1639e7187sm617401iln.50.2022.05.26.09.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 09:19:59 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Remove "-break-insert -r" tests Date: Thu, 26 May 2022 10:19:57 -0600 Message-Id: <20220526161957.1079680-1-tromey@adacore.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 16:20:02 -0000 PR mi/14270 points out that mi-break.exp has some tests for an unimplemented "-r" switch for "-break-insert". This switch was never implemented, and is not documented -- though it is mentioned in a comment in the documentation. This patch removes the test and the doc comment. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=14270 --- gdb/doc/gdb.texinfo | 6 --- gdb/testsuite/gdb.mi/mi-break.exp | 70 ------------------------------- 2 files changed, 76 deletions(-) diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 68679982919..65593965eea 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -31304,12 +31304,6 @@ addr="0x00010774",func="foo",file="recursive2.c", fullname="/home/foo/recursive2.c",line="11",thread-groups=["i1"], times="0"@}]@} (gdb) -@c -break-insert -r foo.* -@c ~int foo(int, int); -@c ^done,bkpt=@{number="3",addr="0x00010774",file="recursive2.c, -@c "fullname="/home/foo/recursive2.c",line="11",thread-groups=["i1"], -@c times="0"@} -@c (gdb) @end smallexample @subheading The @code{-dprintf-insert} Command diff --git a/gdb/testsuite/gdb.mi/mi-break.exp b/gdb/testsuite/gdb.mi/mi-break.exp index 1c5eed3d4b0..b64fe196940 100644 --- a/gdb/testsuite/gdb.mi/mi-break.exp +++ b/gdb/testsuite/gdb.mi/mi-break.exp @@ -96,75 +96,6 @@ proc_with_prefix test_tbreak_creation_and_listing {} { "delete temp breakpoints" } -proc_with_prefix test_rbreak_creation_and_listing {} { - global line_callee4_body - global line_callee3_body - global line_callee2_body - global line_callee1_body - global line_main_body - - # Insert some breakpoints and list them - # Also, disable some so they do not interfere with other tests - # Tests: - # -break-insert -r main - # -break-insert -r callee2 - # -break-insert -r callee - # -break-insert -r .*llee - # -break-list - - setup_kfail "*-*-*" mi/14270 - set bps {} - lappend bps [mi_make_breakpoint -number 5 -file ".*basics.c" \ - -line $line_main_body] - mi_gdb_test "122-break-insert -r main" \ - "122\\^done,[lindex $bps end]" \ - "break-insert -r operation" - - setup_kfail "*-*-*" mi/14270 - lappend bps [mi_make_breakpoint -number 6 -file ".*basics.c" \ - -line $line_callee2_body] - mi_gdb_test "133-break-insert -r callee2" \ - "133\\^done,[lindex $bps end]" \ - "insert breakpoint with regexp callee2" - - setup_kfail "*-*-*" mi/14270 - set start [llength $bps] - lappend bps [mi_make_breakpoint -number 7 -file ".*basics.c" \ - -line $line_callee1_body] - lappend bps [mi_make_breakpoint -number 8 -file ".*basics.c" \ - -line $line_callee2_body] - lappend bps [mi_make_breakpoint -number 9 -file ".*basics.c" \ - -line $line_callee3_body] - lappend bps [mi_make_breakpoint -number 10 -file ".*basics.c" \ - -line $line_callee4_body] - mi_gdb_test "144-break-insert -r callee" \ - "144\\^done,[join [lrange $bps $start end] ,]" \ - "insert breakpoint with regexp callee" - - setup_kfail "*-*-*" mi/14270 - set start [llength $bps] - lappend bps [mi_make_breakpoint -number 11 -file ".*basics.c" \ - -line $line_callee1_body] - lappend bps [mi_make_breakpoint -number 12 -file ".*basics.c" \ - -line $line_callee2_body] - lappend bps [mi_make_breakpoint -number 13 -file ".*basics.c" \ - -line $line_callee3_body] - lappend bps [mi_make_breakpoint -number 14 -file ".*basics.c" \ - -line $line_callee4_body] - mi_gdb_test "155-break-insert -r \.\*llee" \ - "155\\^done,[join [lrange $bps $start end] ,]" \ - "insert breakpoint with regexp .*llee" - - setup_kfail "*-*-*" mi/14270 - mi_gdb_test "166-break-list" \ - "166\\^done,[mi_make_breakpoint_table $bps]" \ - "list of breakpoints" - - mi_gdb_test "177-break-delete" \ - "177\\^done" \ - "delete temp breakpoints" -} - proc_with_prefix test_abreak_creation {} { mi_create_varobj tpnum \$tpnum "create local variable tpnum" # Test that $tpnum is not set before creating a tracepoint. @@ -478,7 +409,6 @@ proc test_break {mi_mode} { mi_gdb_load ${binfile} test_tbreak_creation_and_listing - test_rbreak_creation_and_listing test_ignore_count -- 2.34.1