From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by sourceware.org (Postfix) with ESMTPS id 6F1CA383E690 for ; Fri, 27 May 2022 18:02:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F1CA383E690 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f47.google.com with SMTP id q20so2270180wrc.10 for ; Fri, 27 May 2022 11:02:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=l2RfzUfScxo57V1p613dSsUn7nlyD15NbO6ioJ3QWIo=; b=n933qG3jtR8lZ/8hUb8YG5yR0gMm5joFaNIBdS1+FAlRfnJBGQNyjVzAAjdHZfNz+y ICwWid1qDvAgovS1lm45EiBiJC5omlZ75q+nu+EyzTYGpmoHBfFGJebIvSvAqmWFQH6X F7k1u76mlLwa7wzIpEliyfWe2JORlreqGGNIfrZmOpMtJXCSaRUN2KQm84aYy3khgqsw 0BiQXzonTDSlVyOIWodZZA6yF3Z/27+5Ht2xiEwWNEE1ppMF/2ZtihoG+BeHgJoT0fYG IuTaCuOf4Ycd8XnqRzcsUhxbQ822/1Vz6d2UrBglZlWoXNASHT1D+iiRcbljlsFkAZ9l OlLA== X-Gm-Message-State: AOAM530AD+7TmJG0ReGW2VOL4DPqgEo0sGoUEfG7WUU3yAhU5OS/mlrM lgBbsu8Ff2g1SN4QKMRXWn1JI933xUo= X-Google-Smtp-Source: ABdhPJyo76kFSwDTCDisS0LGsoDUhIrZJxN/jIwRBPoPGLjHtKyfoJbgFY6yxTzz9TxPd+/RGPsvGg== X-Received: by 2002:adf:e2c9:0:b0:20c:dbc2:a411 with SMTP id d9-20020adfe2c9000000b0020cdbc2a411mr35583841wrj.391.1653674572725; Fri, 27 May 2022 11:02:52 -0700 (PDT) Received: from localhost ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id s4-20020a05600c29c400b00397623ff335sm2756651wmd.10.2022.05.27.11.02.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 May 2022 11:02:51 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 0/7] location -> location spec Date: Fri, 27 May 2022 19:02:41 +0100 Message-Id: <20220527180248.2990723-1-pedro@palves.net> X-Mailer: git-send-email 2.36.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2022 18:03:00 -0000 Currently, GDB internally uses the term "location" for both the location specification the user had input, and for actual resolved locations, like the breakpoint locations, or the result of decoding a location spec to SaLs. This is expecially confusing in the breakpoints module. For the location spec, we currently have struct "event_location", and even the "event" part is misnamed. This series everything related to location specifications from "location" to "location spec". event_location is renamed to location_spec. And then cleans up location_spec and its subclasses. Tested on x86_64 GNU/Linux. Pedro Alves (7): event_location -> location_spec Eliminate the two-level data structures behind location_specs Eliminate copy_location_spec Convert location_spec_empty_p to a method Convert location_spec_type to a method Convert location_spec_to_string to a method Convert set_location_spec_string to a method gdb/ada-lang.c | 4 +- gdb/ax-gdb.c | 6 +- gdb/break-catch-throw.c | 17 +- gdb/breakpoint.c | 367 +++++++++-------- gdb/breakpoint.h | 62 +-- gdb/cli/cli-cmds.c | 32 +- gdb/completer.c | 42 +- gdb/elfread.c | 3 +- gdb/guile/scm-breakpoint.c | 21 +- gdb/linespec.c | 157 ++++---- gdb/linespec.h | 12 +- gdb/location.c | 662 ++++++++++++------------------- gdb/location.h | 359 ++++++++++------- gdb/mi/mi-cmd-break.c | 35 +- gdb/probe.c | 8 +- gdb/probe.h | 4 +- gdb/python/py-breakpoint.c | 39 +- gdb/python/py-finishbreakpoint.c | 6 +- gdb/python/python.c | 10 +- gdb/remote.c | 6 +- gdb/tracepoint.c | 6 +- 21 files changed, 877 insertions(+), 981 deletions(-) base-commit: 509e6230915a050d510a36ca9482193c76a6a216 -- 2.36.0