From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by sourceware.org (Postfix) with ESMTPS id 9A02B396E067 for ; Thu, 2 Jun 2022 14:21:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A02B396E067 Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 252DrxRi017966; Thu, 2 Jun 2022 16:21:02 +0200 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3gbc2w0ewh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Jun 2022 16:21:02 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 481C4100034; Thu, 2 Jun 2022 16:21:02 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 4245922AFFA; Thu, 2 Jun 2022 16:21:02 +0200 (CEST) Received: from gnbcxd0114.gnb.st.com (10.75.127.51) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Thu, 2 Jun 2022 16:21:01 +0200 Date: Thu, 2 Jun 2022 16:21:00 +0200 From: Yvan Roux To: CC: Luis Machado , Torbjorn SVENSSON Subject: [PATCH] gdb/arm: Simplify logic for updating addresses Message-ID: <20220602142100.GB23363@gnbcxd0114.gnb.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-02_03,2022-06-02_01,2022-02-23_01 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2022 14:21:06 -0000 Hi, Small performance improvment by fetching the previous SP value only once before the loop and reuse it to avoid fetching at every iteration. Signed-off-by: Torbjörn SVENSSON Signed-off-by: Yvan Roux --- gdb/arm-tdep.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 50ec41a66b1..23e3ad4a072 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -2177,7 +2177,7 @@ arm_make_prologue_cache (struct frame_info *this_frame) { int reg; struct arm_prologue_cache *cache; - CORE_ADDR unwound_fp; + CORE_ADDR unwound_fp, prev_sp; cache = FRAME_OBSTACK_ZALLOC (struct arm_prologue_cache); arm_cache_init (cache, this_frame); @@ -2191,14 +2191,15 @@ arm_make_prologue_cache (struct frame_info *this_frame) arm_gdbarch_tdep *tdep = (arm_gdbarch_tdep *) gdbarch_tdep (get_frame_arch (this_frame)); - arm_cache_set_active_sp_value (cache, tdep, unwound_fp + cache->framesize); + prev_sp = unwound_fp + cache->framesize; + arm_cache_set_active_sp_value (cache, tdep, prev_sp); /* Calculate actual addresses of saved registers using offsets determined by arm_scan_prologue. */ for (reg = 0; reg < gdbarch_num_regs (get_frame_arch (this_frame)); reg++) if (cache->saved_regs[reg].is_addr ()) - cache->saved_regs[reg].set_addr (cache->saved_regs[reg].addr () - + arm_cache_get_prev_sp_value (cache, tdep)); + cache->saved_regs[reg].set_addr (cache->saved_regs[reg].addr () + + prev_sp); return cache; } -- 2.17.1