From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B97F13858406 for ; Thu, 2 Jun 2022 23:04:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B97F13858406 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-10-TAYFvkRLOkuWjlF6MYpaFQ-1; Thu, 02 Jun 2022 19:04:06 -0400 X-MC-Unique: TAYFvkRLOkuWjlF6MYpaFQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD90C3C0CD3C; Thu, 2 Jun 2022 23:04:05 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.17.206]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 735DC40F06B; Thu, 2 Jun 2022 23:04:05 +0000 (UTC) Date: Thu, 2 Jun 2022 16:04:01 -0700 From: Kevin Buettner To: Markus Metzger via Gdb-patches Subject: Re: [PATCH v5 02/15] gdb, solib-svr4: remove locate_base() Message-ID: <20220602160401.4d2c1755@f35-zws-1> In-Reply-To: <20220602132514.957983-3-markus.t.metzger@intel.com> References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-3-markus.t.metzger@intel.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2022 23:04:09 -0000 On Thu, 2 Jun 2022 15:25:01 +0200 Markus Metzger via Gdb-patches wrote: > Whenever we call locate_base(), we clear info->debug_base directly before > the call. Thus, we never cache the base location as locate_base() had > intended. > > Move the svr4_have_link_map_offsets() check into elf_locate_base(), inline > locate_base() at all call sites, and remove it. Okay. Kevin