From: Nils-Christian Kempke <nils-christian.kempke@intel.com>
To: gdb-patches@sourceware.org
Cc: aburgess@redhat.com, JiniSusan.George@amd.com, tdevries@suse.de,
Nils-Christian Kempke <nils-christian.kempke@intel.com>
Subject: [PATCH 1/2] gdb/testsuite: use test_compiler_info in gcc_major_version
Date: Fri, 3 Jun 2022 10:54:13 +0200 [thread overview]
Message-ID: <20220603085414.2391706-2-nils-christian.kempke@intel.com> (raw)
In-Reply-To: <20220603085414.2391706-1-nils-christian.kempke@intel.com>
The procedure gcc_major_version was earlier using the global variable
compiler_info to retrieve gcc's major version. This is discouraged and
(as can be read in a comment in compiler.c) compiler_info should be
local to get_compiler_info and test_compiler_info.
The preferred way of getting the compiler string is via calling
test_compiler_info without arguments. Gcc_major_version was changed to
do that.
gdb/testsuite/ChangeLog:
2022-06-01 Nils-Christian Kempke <nils-christian.kempke@intel.com>
* gdb.exp (gcc_major_version): Use test_compiler_info over
global variable compiler_info.
Signed-off-by: Nils-Christian Kempke <nils-christian.kempke@intel.com>
---
gdb/testsuite/lib/gdb.exp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 402450152a..4ee7c1fb0a 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -4218,12 +4218,11 @@ proc test_compiler_info { {compiler ""} {language ""} } {
# For gcc 7.5.0, the major version 7.
proc gcc_major_version { } {
- global compiler_info
global decimal
if { ![test_compiler_info "gcc-*"] } {
return -1
}
- set res [regexp gcc-($decimal)-($decimal)- $compiler_info \
+ set res [regexp gcc-($decimal)-($decimal)- [test_compiler_info] \
dummy_var major minor]
if { $res != 1 } {
return -1
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2022-06-03 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 8:54 [PATCH 0/2] Fix regressions introduced by Fortran compiler identification series Nils-Christian Kempke
2022-06-03 8:54 ` Nils-Christian Kempke [this message]
2022-06-03 8:54 ` [PATCH 2/2] gdb/testsuite: cache compiler_info on a per language basis Nils-Christian Kempke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220603085414.2391706-2-nils-christian.kempke@intel.com \
--to=nils-christian.kempke@intel.com \
--cc=JiniSusan.George@amd.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).