From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 9B2553841449 for ; Fri, 3 Jun 2022 16:46:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B2553841449 Received: by mail-il1-x134.google.com with SMTP id b17so3177626ilh.6 for ; Fri, 03 Jun 2022 09:46:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yYIL5yNdkkwdBauRJUYf/vEfJeuf3r7BpdsirP4/030=; b=d7KvAgXPl9MfQlrUsLXEv2X5tSAAM1QVNlVersXsbVjTzpyWUf97ECAVXNGisQsgL7 j20bwJo+nLEN+FxwFti0PeCmfMu4dS/iLXMcQwyOx2J/zLN8FuzoTK4UmY82UbZnjNqr HqBVKGpekObhqZrBkfRTycaWs1Gbaocr+NdaPRraLHoeJLaJ4RMWEUl84UF7sPt+e49g DhL76rsXfumQ9aeXV1LuPD5oe9spTNzlj4HJN8NH96aHOBseMkzwXefJU2z3MGczgGVe 2MYHPyqb27Y6BHVJZNWtVdESb4RMvbHXJ5k4uatpv1nDr+lYSXWmK+vRnWRivnCFPpuV xUug== X-Gm-Message-State: AOAM5307GTErNWZoLbJBOWKSwRTPQGBjWPCTPONp37PMRRx5z0PKiwvz C5heAK4vd7ySF0QZX6Y3i7GEGDCDPr9QHQ== X-Google-Smtp-Source: ABdhPJwai67jT8LEqcbWHGqlPcg6hWbejdpyaTSfJC3hIS8+n6nOFN8O9n7DLTuFmZdaaf2287YfbA== X-Received: by 2002:a05:6602:3417:b0:65e:2fae:b371 with SMTP id n23-20020a056602341700b0065e2faeb371mr5418469ioz.98.1654274781869; Fri, 03 Jun 2022 09:46:21 -0700 (PDT) Received: from murgatroyd.Home (71-211-167-178.hlrn.qwest.net. [71.211.167.178]) by smtp.gmail.com with ESMTPSA id 64-20020a021143000000b0033156d6016asm2451988jaf.91.2022.06.03.09.46.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jun 2022 09:46:21 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Check for listeners in emit_exiting_event Date: Fri, 3 Jun 2022 10:46:19 -0600 Message-Id: <20220603164619.1861019-1-tromey@adacore.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2022 16:46:24 -0000 I noticed that emit_exiting_event does not check whether there are any listeners before creating the event object. All other event emitters do this, so this patch updates this one as well. --- gdb/python/python.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdb/python/python.c b/gdb/python/python.c index 9bef2252e88..844e1165de0 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -1936,6 +1936,9 @@ init__gdb_module (void) static int emit_exiting_event (int exit_code) { + if (evregpy_no_listeners_p (gdb_py_events.gdb_exiting)) + return 0; + gdbpy_ref<> event_obj = create_event_object (&gdb_exiting_event_object_type); if (event_obj == nullptr) return -1; -- 2.34.1