From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B459C3858C74 for ; Mon, 6 Jun 2022 11:41:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B459C3858C74 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-332-JCrEzDAiPQipU6fqXGwwWw-1; Mon, 06 Jun 2022 07:40:59 -0400 X-MC-Unique: JCrEzDAiPQipU6fqXGwwWw-1 Received: by mail-wm1-f71.google.com with SMTP id n15-20020a05600c4f8f00b0039c3e76d646so4238951wmq.7 for ; Mon, 06 Jun 2022 04:40:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D2FznldBPCOS8NGteCsvpQuLSHBMQqU1zqPoeme9hrE=; b=gLyIhMsOTiMkgp7y/E92nM2Cb62eob50qi5M34+ESua41fhCb+H03L8XcG8YFtkgk5 Xifp2CpBix9vERHZpqGjbMPgS1dAefNLg3FmEd8guvKqpCaYL867LmwBs7dmWqFYKk0w 6h1XmjDZ2n7x0SV3CJ40Dp23wkq9wLyk7133axZVDuvLvZOOmPrTuZWzi6GQ3mU9QiJ9 t6lurbB7HzgNHFJmu25IBJUXxPIlUuxVQW4BkhrymuA5GRdDCZG0lbYNWTv4rV2fH2pV LAVHCU2zLmY51+pa6uzGsYzrku4sCqKjyObBWo02deun2JmyIwC3Ly0vd3y0LEFPP1FG 2r0A== X-Gm-Message-State: AOAM530MUWh7ABb1VOT1aj6/GRW27S1VaFuhrCGsT1X7yv5bGXbDOcF5 SzIiRcX73bYmOTYIQp1DCrQSrHQO2jQ6o+h4UdOXSNA+HM0QzFiCrWk8tjx06opS0/GZa4C8qq8 BpJzev/ORh40XpuFq+VfgZHOGBa3S6dwugQ0y6iyaKYnybN7/t66jb4OFGneIzey8+wVYMXa5DQ == X-Received: by 2002:adf:f688:0:b0:215:6e4d:4103 with SMTP id v8-20020adff688000000b002156e4d4103mr14227828wrp.372.1654515658482; Mon, 06 Jun 2022 04:40:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9EdjTv0vh9+TDEqAkdL6GObKXgTOsAHfR8qUepg93h8T0t8A+h3pgXEYYDbX/HEapU4GXnQ== X-Received: by 2002:adf:f688:0:b0:215:6e4d:4103 with SMTP id v8-20020adff688000000b002156e4d4103mr14227800wrp.372.1654515658204; Mon, 06 Jun 2022 04:40:58 -0700 (PDT) Received: from localhost (host109-152-215-36.range109-152.btcentralplus.com. [109.152.215.36]) by smtp.gmail.com with ESMTPSA id m11-20020a5d624b000000b0020ff3a2a925sm18654885wrv.63.2022.06.06.04.40.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 04:40:57 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PUSHED] gdb/testsuite: add missing skip_python_tests call in py-doc-reformat.exp Date: Mon, 6 Jun 2022 12:40:55 +0100 Message-Id: <20220606114055.52878-1-aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: <5ad1534d98e1c6132722d663180a97ebcc2075df.camel@us.ibm.com> References: <5ad1534d98e1c6132722d663180a97ebcc2075df.camel@us.ibm.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2022 11:41:07 -0000 Carl, Thanks for bringing this to my attention. Sorry for the slow reply, I've been away for a couple of days. The problem was that I had missed a call to skip_python_tests in the new test script. Recently, GDB was changed so that it will no longer build against Python 2, this means on machines without Python 3 there will be no Python support, the 'source' command used in the test will then fail. The correct fix is to check that GDB has Python support at the top of the test script, which this commit does. Thanks, Andrew --- In commit: commit 51e8dbe1fbe7d8955589703140ca5eba7b4f1bd7 Date: Mon May 16 19:26:54 2022 +0100 gdb/python: improve formatting of help text for user defined commands the test that was added (gdb.python/py-doc-reformat.exp) was missing a call to skip_python_tests. As a result, this test would fail for any GDB built within Python support. This commit adds a call to skip_python_tests. --- gdb/testsuite/gdb.python/py-doc-reformat.exp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/testsuite/gdb.python/py-doc-reformat.exp b/gdb/testsuite/gdb.python/py-doc-reformat.exp index aae3939bd07..f0cfa278557 100644 --- a/gdb/testsuite/gdb.python/py-doc-reformat.exp +++ b/gdb/testsuite/gdb.python/py-doc-reformat.exp @@ -19,6 +19,10 @@ load_lib gdb-python.exp +# Check that Python is supported. +clean_restart +if { [skip_python_tests] } { continue } + # A global counter used to number the tests. set idx 0 -- 2.25.4