From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1A1323814FCA for ; Tue, 7 Jun 2022 12:59:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1A1323814FCA Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-253-WVCnSRyIMmaytv2pvGgQTw-1; Tue, 07 Jun 2022 08:59:36 -0400 X-MC-Unique: WVCnSRyIMmaytv2pvGgQTw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 443BA804193 for ; Tue, 7 Jun 2022 12:59:36 +0000 (UTC) Received: from blarsen.com (ovpn-116-38.gru2.redhat.com [10.97.116.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5C7B47AD8; Tue, 7 Jun 2022 12:59:34 +0000 (UTC) From: Bruno Larsen To: gdb-patches@sourceware.org Subject: RE: [PATCH v3 03/14] change gdb.base/symbol-alias to xfail with clang Date: Tue, 7 Jun 2022 09:53:47 -0300 Message-Id: <20220607125346.14861-1-blarsen@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 12:59:42 -0000 Hi Jini, Great to hear that Kavitha's changes have landed on clang! I do think that it is still important to have xfails, however, since only new clangs would add the information, and GDB is tested in all manner of systems. I have changed the patch to assume that clang 15 has Kavitha's patches, and changed the clang compiler test. Does this look acceptable? [PATCH v4 03/14] gdb/testsuite: Change gdb.base/symbol-alias to xfail with old clang Clang didn't use to add alias information, even when using -gfull. This commit checks if the clang version being used is already providing alias information (15 or newer), otherwise it adds an XFAIL. --- gdb/testsuite/gdb.base/symbol-alias.exp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.base/symbol-alias.exp b/gdb/testsuite/gdb.base/symbol-alias.exp index 289f49bbc3f..078158dc101 100644 --- a/gdb/testsuite/gdb.base/symbol-alias.exp +++ b/gdb/testsuite/gdb.base/symbol-alias.exp @@ -31,6 +31,11 @@ foreach f {"func" "func_alias"} { } # Variables. -foreach v {"g_var_s" "g_var_s_alias"} { - gdb_test "p $v" "= {field1 = 1, field2 = 2}" +gdb_test "p g_var_s" "= {field1 = 1, field2 = 2}" + +# Clang didn't include alias information until version 15. +if {[test_compiler_info {clang-[1-9]*}] + || [test_compiler_info {clang-1[0-4]*}]} { + setup_xfail "clang/52664" *-*-* } +gdb_test "p g_var_s_alias" "= {field1 = 1, field2 = 2}" -- 2.31.1