From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH] Fix end of CU calculation in cooked_indexer::index_dies
Date: Thu, 9 Jun 2022 09:24:49 -0600 [thread overview]
Message-ID: <20220609152449.648226-1-tom@tromey.com> (raw)
cooked_indexer::index_dies incorrect computes the end of the current
CU in the .debug_info. This isn't readily testable without writing
intentionally corrupt DWARF, but it's apparent through observation: it
is currently based on 'info_ptr', which does not always point to the
start of the CU. This patch fixes the expression. Tested on x86-64
Fedora 34.
---
gdb/dwarf2/read.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 696277d931a..403f00c3b95 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -18276,7 +18276,9 @@ cooked_indexer::index_dies (cutu_reader *reader,
const cooked_index_entry *parent_entry,
bool fully)
{
- const gdb_byte *end_ptr = info_ptr + reader->cu->header.get_length ();
+ const gdb_byte *end_ptr = (reader->buffer
+ + to_underlying (reader->cu->header.sect_off)
+ + reader->cu->header.get_length ());
while (info_ptr < end_ptr)
{
--
2.34.1
next reply other threads:[~2022-06-09 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 15:24 Tom Tromey [this message]
2022-06-25 17:10 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220609152449.648226-1-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).