From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] gdb/testsuite: Relax RE for missing compiler in gdb_compile_test
Date: Mon, 13 Jun 2022 21:53:28 -0300 [thread overview]
Message-ID: <20220614005328.427903-1-thiago.bauermann@linaro.org> (raw)
In Linaro's CI environment GNATMAKE_FOR_TARGET contains flags such as
"--sysroot=..." and "-Wl,...". Because of that, it contains spaces.
Since gdb_compile_test's regular expression to detect a missing compiler
doesn't allow spaces, and also since the Linaro CI isn't available the Ada
testcases which need to build a test binary fail instead of being marked as
unsupported.
Therefore relax the regexp so that it matches output containing spaces.
---
gdb/testsuite/lib/gdb.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 75efc4a62d1a..5ab566d1d569 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2303,7 +2303,7 @@ proc gdb_compile_test {src output} {
return
}
- if { [regexp {^[a-zA-Z_0-9]+: Can't find [^ ]+\.$} $output]
+ if { [regexp {^[a-zA-Z_0-9]+: Can't find .+\.$} $output]
|| [regexp {.*: command not found[\r|\n]*$} $output]
|| [regexp {.*: [^\r\n]*compiler not installed[^\r\n]*[\r|\n]*$} $output] } {
unsupported "$msg (missing compiler)"
base-commit: c2ac533e98438df5e5c2c58cce104c927ad42d09
reply other threads:[~2022-06-14 1:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614005328.427903-1-thiago.bauermann@linaro.org \
--to=thiago.bauermann@linaro.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).