From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9F254385E442 for ; Sun, 19 Jun 2022 04:22:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9F254385E442 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-627-ZA8UO7ysMCW8jJasNY4P9A-1; Sun, 19 Jun 2022 00:22:54 -0400 X-MC-Unique: ZA8UO7ysMCW8jJasNY4P9A-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EEBC180B91C; Sun, 19 Jun 2022 04:22:53 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9918E456CD9; Sun, 19 Jun 2022 04:22:53 +0000 (UTC) Date: Sat, 18 Jun 2022 21:22:51 -0700 From: Kevin Buettner To: Markus Metzger via Gdb-patches Subject: Re: [PATCH v5 04/15] gdbserver: move main_lm handling into caller Message-ID: <20220618212251.533db670@f35-zws-1> In-Reply-To: <20220602132514.957983-5-markus.t.metzger@intel.com> References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-5-markus.t.metzger@intel.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2022 04:22:58 -0000 On Thu, 2 Jun 2022 15:25:03 +0200 Markus Metzger via Gdb-patches wrote: > When listing SVR4 shared libraries, special care has to be taken about the > first library in the default namespace as that refers to the main > executable. The load map address of this main executable is provided in > an attribute of the library-list-svr4 element. > > Move that code from where we enumerate libraries inside a single namespace > to where we generate the rest of the library-list-svr4 element. This > allows us to complete the library-list-svr4 element inside one function. > > There should be no functional change. > --- > gdbserver/linux-low.cc | 96 +++++++++++++++++++++--------------------- > 1 file changed, 48 insertions(+), 48 deletions(-) LGTM. Kevin