From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3D1FD385AE53 for ; Fri, 24 Jun 2022 17:19:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D1FD385AE53 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-98-0dv_ZwmxPLSV4uUteN0KGw-1; Fri, 24 Jun 2022 13:18:57 -0400 X-MC-Unique: 0dv_ZwmxPLSV4uUteN0KGw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 53D993C0E22D; Fri, 24 Jun 2022 17:18:57 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E10901410DD8; Fri, 24 Jun 2022 17:18:56 +0000 (UTC) Date: Fri, 24 Jun 2022 10:18:55 -0700 From: Kevin Buettner To: Markus Metzger via Gdb-patches Subject: Re: [PATCH v5 07/15] gdb, python: use gdbarch_iterate_over_objfiles_in_search_order Message-ID: <20220624101855.5f7c6ae4@f35-zws-1> In-Reply-To: <20220602132514.957983-8-markus.t.metzger@intel.com> References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-8-markus.t.metzger@intel.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 17:19:03 -0000 On Thu, 2 Jun 2022 15:25:06 +0200 Markus Metzger via Gdb-patches wrote: > The implementation of gdb.lookup_objfile() iterates over all objfiles and > compares their name or build id to the user-provided search string. > > This will cause problems when supporting linker namespaces as the first > objfile in any namespace will be found. Instead, use > gdbarch_iterate_over_objfiles_in_search_order to only consider the > namespace of gdb.current_objfile() for the search, which defaults to the > initial namespace when gdb.current_objfile() is None. > --- > gdb/python/py-objfile.c | 116 +++++++++++++++++++--------------------- > gdb/python/python.c | 7 +-- > gdb/python/python.h | 6 +++ > 3 files changed, 64 insertions(+), 65 deletions(-) Okay. Kevin