From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E62403852756 for ; Fri, 24 Jun 2022 23:42:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E62403852756 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-367-cz51tDE5N4WR7xKDZXK4fQ-1; Fri, 24 Jun 2022 19:42:35 -0400 X-MC-Unique: cz51tDE5N4WR7xKDZXK4fQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 69629801E67; Fri, 24 Jun 2022 23:42:34 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F2BF2141510C; Fri, 24 Jun 2022 23:42:33 +0000 (UTC) Date: Fri, 24 Jun 2022 16:42:32 -0700 From: Kevin Buettner To: Markus Metzger via Gdb-patches Subject: Re: [PATCH v5 09/15] gdb, ada: update ada_lookup_simple_minsym Message-ID: <20220624164232.0813347d@f35-zws-1> In-Reply-To: <20220602132514.957983-10-markus.t.metzger@intel.com> References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-10-markus.t.metzger@intel.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 23:42:41 -0000 On Thu, 2 Jun 2022 15:25:08 +0200 Markus Metzger via Gdb-patches wrote: > Iterate over objfile in search order using the objfile of the context > block as current_objfile so the iteration can stay inside the block's > linker namespace. > --- > gdb/ada-exp.y | 9 ++++++++- > gdb/ada-lang.c | 32 ++++++++++++++++++-------------- > gdb/ada-lang.h | 3 ++- > 3 files changed, 28 insertions(+), 16 deletions(-) LGTM. Kevin