From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B484C3856087 for ; Sat, 25 Jun 2022 00:01:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B484C3856087 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-668-vsbfwe-zPsik7tzrPdfKIA-1; Fri, 24 Jun 2022 20:01:03 -0400 X-MC-Unique: vsbfwe-zPsik7tzrPdfKIA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 030ED1C06EE1; Sat, 25 Jun 2022 00:01:03 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B335D2026D64; Sat, 25 Jun 2022 00:01:02 +0000 (UTC) Date: Fri, 24 Jun 2022 17:01:01 -0700 From: Kevin Buettner To: Markus Metzger via Gdb-patches Subject: Re: [PATCH v5 12/15] gdb, hppa: remove unused hppa_lookup_stub_minimal_symbol Message-ID: <20220624170101.63e7aa9e@f35-zws-1> In-Reply-To: <20220602132514.957983-13-markus.t.metzger@intel.com> References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-13-markus.t.metzger@intel.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jun 2022 00:01:05 -0000 On Thu, 2 Jun 2022 15:25:11 +0200 Markus Metzger via Gdb-patches wrote: > I stumbled over this while reviewing all objfiles traversals with regards > to impact of linker namespaces. > > Recursive grep only finds two occurrences of hppa_lookup_stub_minimal_symbol: > - the declaration in hppa-tdep.h. > - the definition in hppa-tdep.c. > > There appear to be no calls to this function. Remove it. > --- > gdb/hppa-tdep.c | 31 ------------------------------- > gdb/hppa-tdep.h | 4 ---- > 2 files changed, 35 deletions(-) Okay. Kevin