public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Ari Hannula <ari.hannula@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v3 0/2] Function call history patches (MI)
Date: Wed,  6 Jul 2022 15:36:37 +0200	[thread overview]
Message-ID: <20220706133639.114681-1-ari.hannula@intel.com> (raw)

Hi all,

again on behalf of Tim, I am posting another revision of the function
call history MI commands. This time I have fixed the issues found from v2
by the reviewers. Additionally I have fixed some issues, which I found
just recently and those are commented in the commit messages.

To recap, the new MI command -function-call-history gets the data from
record-btrace.c which had some issues related to the naming of the MI
fields which I assumed are not allowed to have spaces in them. I have
therefore renamed the field names. See the documentation. There should
not be any backwards compatibility issues since this is a new MI command
which has not yet been used by any clients.

I have added documentation for the commands to gdb.texinfo.

I have fixed and amended some issues in the tests.

Link to v2: https://sourceware.org/pipermail/gdb-patches/2022-April/188360.html

Tim Wiederhake (2):
  [func_call] Add function-call-history-length command to MI.
  [func_call] Add function-call-history command to MI.

 gdb/Makefile.in                               |   1 +
 gdb/doc/gdb.texinfo                           | 126 ++++++++++++
 gdb/mi/mi-cmd-record.c                        |  85 ++++++++
 gdb/mi/mi-cmd-record.h                        |  32 +++
 gdb/mi/mi-cmds.c                              |   3 +
 gdb/mi/mi-cmds.h                              |   2 +
 gdb/record-btrace.c                           |  34 +++-
 gdb/record.c                                  |  28 +--
 gdb/record.h                                  |  18 ++
 gdb/target-delegates.c                        |  27 +++
 gdb/target.c                                  |   8 +
 gdb/target.h                                  |   7 +
 .../gdb.mi/mi-function_call_history.c         |  43 ++++
 .../gdb.mi/mi-function_call_history.exp       | 184 ++++++++++++++++++
 14 files changed, 576 insertions(+), 22 deletions(-)
 create mode 100644 gdb/mi/mi-cmd-record.c
 create mode 100644 gdb/mi/mi-cmd-record.h
 create mode 100644 gdb/testsuite/gdb.mi/mi-function_call_history.c
 create mode 100644 gdb/testsuite/gdb.mi/mi-function_call_history.exp

-- 
2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


             reply	other threads:[~2022-07-06 13:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06 13:36 Ari Hannula [this message]
2022-07-06 13:36 ` [PATCH v3 1/2] [func_call] Add function-call-history-length command to MI Ari Hannula
2022-07-06 13:45   ` Eli Zaretskii
2022-07-06 13:36 ` [PATCH v3 2/2] [func_call] Add function-call-history " Ari Hannula
2022-07-06 13:51   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220706133639.114681-1-ari.hannula@intel.com \
    --to=ari.hannula@intel.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).