From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6EF713857431 for ; Sat, 9 Jul 2022 09:10:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6EF713857431 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-288-2K7TkcbOPYqK4yMamPLbuA-1; Sat, 09 Jul 2022 05:10:45 -0400 X-MC-Unique: 2K7TkcbOPYqK4yMamPLbuA-1 Received: by mail-wm1-f70.google.com with SMTP id a6-20020a05600c348600b003a2d72b7a15so2159790wmq.9 for ; Sat, 09 Jul 2022 02:10:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YaAIyrXRx6Nf/iUJ9EP9pZKhoiKym2beciYIPSMUmh4=; b=1MAOtvGhMTllPTdOVR4c9UFiaQ+Y7m/FCyxQuBeQ1tm7hrdTBciRgfIAExqPOLHNE8 vfQ6yh3/kaZImYauP4KjMuEfImZEPDxQEt3G7VFtP6ivwnxCDtjd1gQ/yy2yJORC6FTs hOlbKhFOTZxSr72rc4yPDxmYNAWoNNIaeJ+7zJw1shLAJsVCAdGobdmNkA9sHOr++j8Y MGvYMhHzeOhYBjTY8/cIMmZFkAXpBk0MWk45IN7XSHCaEIS5ORiJTbqMadn9fgOBWWYo CMWaugsur6H3EazUd2WEiMGqUOe61MH8r1wz1rUyElUrbHAZXrwRguQ6kezAvLC9tsD/ 1Lrw== X-Gm-Message-State: AJIora+0aLKDiBiPvrWD2u9k/P9VnVFdukXMlw1QYEoW4hPPqC1UTK03 QkjsUz5IlM6O0bfv9XyWfaJhqu15Z92H4xbIrFYiJ6Wtjn92Joq55Fpz9xnVTHZ/MUS6HTOB1PB pJXwVeAX9hnGuGRYFCdosuw== X-Received: by 2002:adf:fb46:0:b0:210:2316:dd02 with SMTP id c6-20020adffb46000000b002102316dd02mr7336454wrs.557.1657357844534; Sat, 09 Jul 2022 02:10:44 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uwnWQUHv3acEd7N8Io7fdiEYZLcP22UbraQXxycunPZ8jtHSCfIoEXNnjCt8AHX3GosvEFUQ== X-Received: by 2002:adf:fb46:0:b0:210:2316:dd02 with SMTP id c6-20020adffb46000000b002102316dd02mr7336432wrs.557.1657357844356; Sat, 09 Jul 2022 02:10:44 -0700 (PDT) Received: from localhost (92.40.178.149.threembb.co.uk. [92.40.178.149]) by smtp.gmail.com with ESMTPSA id n8-20020a7bc5c8000000b0039c457cea21sm951127wmk.34.2022.07.09.02.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 02:10:43 -0700 (PDT) Date: Sat, 9 Jul 2022 10:10:40 +0100 From: Andrew Burgess To: Christopher Di Bella Cc: gdb-patches@sourceware.org, manojgupta@google.com Subject: Re: [PATCH] [PATCH] [gdb] adds `` to list of includes Message-ID: <20220709091040.GA468400@redhat.com> References: <20220628010427.1856503-1-cjdb@google.com> MIME-Version: 1.0 In-Reply-To: <20220628010427.1856503-1-cjdb@google.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 10:08:53 up 1 day, 18:53, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jul 2022 09:10:48 -0000 * Christopher Di Bella via Gdb-patches [2022-06-28 01:04:27 +0000]: > `std::back_inserter` is defined in ``, which is currently > being transitively included by one of the other headers. This is causing > gdb to fail to build on certain platforms, which is fixed by explicitly > including it. Hi Christopher, Thanks for this fix. If you could update the commit message with the additional information that Manoj provided then repost, and we can get this merged. Thanks, Andrew > --- > gdb/value.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gdb/value.c b/gdb/value.c > index 022fca91a42..ba7ae1a0e18 100644 > --- a/gdb/value.c > +++ b/gdb/value.c > @@ -40,6 +40,7 @@ > #include "cp-abi.h" > #include "user-regs.h" > #include > +#include > #include "completer.h" > #include "gdbsupport/selftest.h" > #include "gdbsupport/array-view.h" > -- > 2.37.0.rc0.161.g10f37bed90-goog >