From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by sourceware.org (Postfix) with ESMTPS id 1E668388B6B6 for ; Wed, 13 Jul 2022 22:25:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1E668388B6B6 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f47.google.com with SMTP id v67-20020a1cac46000000b003a1888b9d36so2065858wme.0 for ; Wed, 13 Jul 2022 15:25:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v4uZ/GeEN2PoAKvMI0V5NFe5ycOhgHQHb/Pfr95A3MM=; b=IhSB+zzyK9CceTlguyqRbEH6LygBllXRewmzv2VwBJs7WipCtNoMzfTcy+zmumqCPi C/bHldTMiq0R9RdtmSiX2+m2EYzIgK/NRKHbTF9neCiHl3mcWMT+U9Yubm4i0PSmoCQ+ 0PwMv2+0TdwIXv1zTsgjE/hvH93Is78H1eNSkQDTMJF9I6aTV7Unf9iaoMduTd51EN1E R+KHhTTk7n3/dGIOKZgn6yHYxSNsO4O2cDlOZi0tf8qzMX8PUDunRcp0VYNkpHgQnhH9 LMejsHSAKIeGks74ON+2oqSexnCCxhkyJjbRxLV+mXCT6rfG9pLiJj/gqYVNg5cGsV8g THBQ== X-Gm-Message-State: AJIora+1KjD0ieEab9UCQryVjsZaITC5BiAmQovPfWMiQhBXFRrZJKir Hy8sb2P/3X0MV+7MdxB2bWEcAnzvGW0= X-Google-Smtp-Source: AGRyM1t18Q60iYcfb5bJ4I5RwM/F0e0LeJxmZP0fQVN4bfVQzE6v2NEH3EJYckV4ibbHP2kN08Xt/Q== X-Received: by 2002:a05:600c:3b96:b0:3a2:e0ae:f127 with SMTP id n22-20020a05600c3b9600b003a2e0aef127mr11617708wms.64.1657751106591; Wed, 13 Jul 2022 15:25:06 -0700 (PDT) Received: from localhost ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id z15-20020a056000110f00b0021d6c7a9f50sm13624538wrw.41.2022.07.13.15.25.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 15:25:05 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH v2 14/29] gdbserver/linux-low.cc: Ignore event_ptid if TARGET_WAITKIND_IGNORE Date: Wed, 13 Jul 2022 23:24:18 +0100 Message-Id: <20220713222433.374898-15-pedro@palves.net> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220713222433.374898-1-pedro@palves.net> References: <20220713222433.374898-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 22:25:09 -0000 gdbserver's linux_process_target::wait loops if called sync mode, and wait_1 returns TARGET_WAITKIND_IGNORE, _and_ wait_1 also returns null_ptid. The null_ptid check fails however when this path is taken: ptid_t linux_process_target::filter_exit_event (lwp_info *event_child, target_waitstatus *ourstatus) { ... if (!is_leader (thread)) { if (report_exit_events_for (thread)) ourstatus->set_thread_exited (0); else ourstatus->set_ignore (); <<<<<<< delete_lwp (event_child); } return ptid; } This makes linux_process_target::wait return TARGET_WAITKIND_IGNORE in sync mode, which is unexpected by the core and fails an assertion. This commit fixes it by just making linux_process_target::wait loop if it got a TARGET_WAITKIND_IGNORE, irrespective of event_ptid. Change-Id: I39776908a6c75cbd68aa04139ffcf7be334868cf --- gdbserver/linux-low.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc index 3a95d820cde..2568fa10ad4 100644 --- a/gdbserver/linux-low.cc +++ b/gdbserver/linux-low.cc @@ -3638,7 +3638,6 @@ linux_process_target::wait (ptid_t ptid, event_ptid = wait_1 (ptid, ourstatus, target_options); } while ((target_options & TARGET_WNOHANG) == 0 - && event_ptid == null_ptid && ourstatus->kind () == TARGET_WAITKIND_IGNORE); /* If at least one stop was reported, there may be more. A single -- 2.36.0