From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by sourceware.org (Postfix) with ESMTPS id 3F2F8382C162 for ; Wed, 13 Jul 2022 22:24:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3F2F8382C162 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f50.google.com with SMTP id be14-20020a05600c1e8e00b003a04a458c54so149955wmb.3 for ; Wed, 13 Jul 2022 15:24:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YDcbJqujG50lzqpRq6n2aZD3Qu/f6zLqwS1z0TO6ID4=; b=LGYaDJ9lPjKP3ILd4oRb0c7HnmXMcZinJRllDfgT8rWlrOL/2V27CwQEXcOOtmUoJW cEhccthVZWuOmAewhZ4YAtWRpF+L4ujGvRtaUY3b/OOibPcl7cgj1TT/jAmkZF1k0jPW kVqe7WMGRLl7pinKvPGAPeODclBHzb/YmBT6qzxedtVJ8kS/WFm8tztN+rMBtHM+4vH4 nyua6zhrft8rkknmBTUK96Cp433xg92wAhUwYlJSF0svTjTgX4LeqpnBl7kF/u/rDwI9 akZ13cDJAhQXYS9jmrWz7AvuvQQWgZVQPF0aIvuDnOFvW4VWltpVlIez/+4RV2KrDOO4 jE4Q== X-Gm-Message-State: AJIora/tX4IQ4urFAeATF8cELH6ieskNDUS9xLeObXqgliUXIzDZDFe5 bGkp0V+LGiFfuE+1XvDA+CxDM6tpmnA= X-Google-Smtp-Source: AGRyM1sWZf1Belxpn5LQe2owVCndu5nc3OXmUYD8bHNjX+u1tpl4WtFmw5FC2ofqQmDw9rbJmCxweg== X-Received: by 2002:a05:600c:3d0e:b0:3a1:8cf3:3f1c with SMTP id bh14-20020a05600c3d0e00b003a18cf33f1cmr5934055wmb.0.1657751088595; Wed, 13 Jul 2022 15:24:48 -0700 (PDT) Received: from localhost ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id v18-20020a5d6792000000b0021d4155cd6fsm12171042wru.53.2022.07.13.15.24.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 15:24:47 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH v2 06/29] Avoid duplicate QThreadEvents packets Date: Wed, 13 Jul 2022 23:24:10 +0100 Message-Id: <20220713222433.374898-7-pedro@palves.net> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220713222433.374898-1-pedro@palves.net> References: <20220713222433.374898-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 22:24:51 -0000 Similarly to QProgramSignals and QPassSignals, avoid sending duplicate QThreadEvents packets. Change-Id: Iaf5babb0b64e1527ba4db31aac8674d82b17e8b4 --- gdb/remote.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gdb/remote.c b/gdb/remote.c index c0bd075e9e5..00ed82dc466 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -314,6 +314,10 @@ class remote_state the target know about program signals list changes. */ char *last_program_signals_packet = nullptr; + /* Similarly, the last QThreadEvents state we sent to the + target. */ + bool last_thread_events; + gdb_signal last_sent_signal = GDB_SIGNAL_0; bool last_sent_step = false; @@ -14584,6 +14588,9 @@ remote_target::thread_events (int enable) if (packet_support (PACKET_QThreadEvents) == PACKET_DISABLE) return; + if (rs->last_thread_events == enable) + return; + xsnprintf (rs->buf.data (), size, "QThreadEvents:%x", enable ? 1 : 0); putpkt (rs->buf); getpkt (&rs->buf, 0); @@ -14594,6 +14601,7 @@ remote_target::thread_events (int enable) case PACKET_OK: if (strcmp (rs->buf.data (), "OK") != 0) error (_("Remote refused setting thread events: %s"), rs->buf.data ()); + rs->last_thread_events = enable; break; case PACKET_ERROR: warning (_("Remote failure reply: %s"), rs->buf.data ()); -- 2.36.0